Opened 3 months ago

Closed 3 months ago

#21774 closed defect (fixed)

Fix CONN_BW event listening

Reported by: timonh Owned by: atagar
Priority: Low Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The ConnectionBandwidthEvent overwrites the type field of the Event class.
Therefore the method _handle_event in control.py erroneously checks if the connection type (if it is a ConnectionBandwidthEvent) is contained in the event listeners list.
All in all you can't receive CONN_BW events in stem.
I fixed it by renaming the type of the ConnectionBandwidthEvent to conn_type.

My changes can be found here: https://github.com/kithack/stem/commit/23fe7b6cbd69c6209657c9531a21502a67ecf5e5

Child Tickets

Change History (2)

comment:1 Changed 3 months ago by atagar

Great, thanks timonh for the pull request! I'm traveling until the 26th during which I can't merge anything, but change looks great and I'll pull it in when I get back.

Thanks for the patch!

comment:2 Changed 3 months ago by atagar

  • Resolution set to fixed
  • Status changed from new to closed

Sorry about the long delay! Fix merged.

Note: See TracTickets for help on using tickets.