#21778 closed defect (fixed)

Canvas prompt is not showing up anymore in Tor Browser based in ESR52

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, tbb-7.0-must-alpha, tbb-e10s, TorBrowserTeam201704R
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Going to https://github.com gives regularly the canvas prompt asking users what to do with a website wanting to access the canvas.

This is not happening anymore with an ESR52 based Tor Browser. Other sites are probably affected as well.

The blocking note is still visible on the browser console, though.

Child Tickets

Change History (12)

comment:1 Changed 21 months ago by mcs

Cc: brade mcs added

When I tested on OSX, disabling e10s mode made the prompt work again.

comment:2 Changed 21 months ago by mcs

Keywords: tbb-7.0-must-alpha added

This is a regression. Unless we plan to disable e10s, we should try to fix this for the alpha.

comment:3 Changed 20 months ago by gk

Priority: MediumHigh

comment:4 Changed 20 months ago by gk

Keywords: tbb-e10s added

Adding e10s keyword to track multiprocess related bugs.

comment:5 Changed 20 months ago by mcs

Keywords: TorBrowserTeam201704R added
Status: newneeds_review

It took a lot longer than we expected to find a working solution, but here is a fix for review:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug21778-01&id=04b228b078c98cabedc0ccc179d627d693884a42

comment:6 Changed 20 months ago by cypherpunks

Hrr, this annoying popup again! Leave it for dumb users on Low Security only!

comment:7 in reply to:  5 Changed 20 months ago by arthuredelstein

Replying to mcs:

It took a lot longer than we expected to find a working solution, but here is a fix for review:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug21778-01&id=04b228b078c98cabedc0ccc179d627d693884a42

Nice work! Looks good to me.

comment:8 Changed 20 months ago by gk

Looks good to me, too. Just one nit:

+    try {
+      browser = aSubject.QueryInterface(Ci.nsIBrowser);
+   } catch (e) {}

(indentation).

comment:10 Changed 20 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. This is commit 1182bee9789a632f374f0a6d3ed90f21af1e37c5 on tor-browser-52.1.0esr-7.0-2 now.

comment:11 Changed 16 months ago by cypherpunks

Resolution: fixed
Status: closedreopened

Can't you just leave people who use "High" security? This popup is very annoying.

comment:12 in reply to:  11 Changed 16 months ago by cypherpunks

Resolution: fixed
Status: reopenedclosed

Replying to cypherpunks:

Can't you just leave people who use "High" security? This popup is very annoying.

There's a related bug on Mozilla's bug tracker about not showing this popup until there's some user input, please don't mess up other tickets.

Note: See TracTickets for help on using tickets.