Opened 3 years ago

Last modified 3 years ago

#21789 new enhancement

Use cached address values more often

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 031-deferred-20170425, 032-unreached
Cc: Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor:


arma said in #20423:

Once we get this one in, we might in 0.3.0 consider changing many more of these calls to cache_only=1. In fact, if we leave check_descriptor_ipaddress_changed() calling resolve_my_address() once a minute, maybe we're all set and the whole of router_pick_published_address() can just look at the cached values? I didn't want to make an invasive change like that in 0.2.9 though, since there are probably edge cases we care about, e.g. where getinfo_helper_misc() calls router_pick_published_address() and we're not a relay so we've never called resolve_my_address() before that very moment.

Child Tickets

#20423defectreopenedClock jumps on relay due to hostname lookup timeouts
#23116defectnewtor stops responding to Ctrl-C and circuits while in infinite descriptor download loop
#23470defectclosedAvoid relays resolving their own address on every download status check

Change History (2)

comment:1 Changed 3 years ago by nickm

Keywords: 031-deferred-20170425 added
Milestone: Tor: 0.3.1.x-finalTor: 0.3.2.x-final

Triage: batch-defer unowned items of priority Medium or lower to 0.3.2.

comment:2 Changed 3 years ago by nickm

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Mark a large number of tickets that I do not think we will do for 0.3.2.

Note: See TracTickets for help on using tickets.