Tor Browser is crashing on github.com on Windows

A user reported that Tor Browser on Windows is crashing reliably when going to https://help.github.com/categories/writing-on-github/. This happens with Tor Browser 6.5.1.

added TorBrowserTeam201704R component::applications/tor browser owner::tbb-team priority::very high resolution::fixed severity::critical status::closed tbb-crash type::defect labels

kidding?

Trac:
Cc: N/A to arthuredelstein@gmail.com

https://help.github.com/assets/javascripts/application.js Tor Browser with High Security is not affected, Win XP is not affected. Is this the SSP in action?

@gk I can confirm: tested on latest Tor Browser (6.5.1) security settings set to Low with Windows 7 32bits SP1.

Trac:
Username: lolscreen

I filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1351278

Remmove remaining tickets over to April

Trac:
Keywords: TorBrowserTeam201703 deleted, TorBrowserTeam201704 added

Trac:
Keywords: N/A deleted, tbb-crash added

I think I have a workaround that does not look awful: bug_21795 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_21795&id=fd67e2869611a961893a868fa0891cf4ded173eb). Please review.

Trac:
Cc: arthuredelstein@gmail.com to arthuredelstein@gmail.com, mcs, brade
Keywords: TorBrowserTeam201704 deleted, TorBrowserTeam201704R added

Trac:
Status: new to needs_review

r=brade,r=mcs This looks okay to us; I guess Mozilla may come up with a differemt fix but we can pick that up later.

Pushed as commit fd67e2869611a961893a868fa0891cf4ded173eb to tor-browser-45.8.0esr-6.5-2. It seems that esr52 is somehow not affected as I can't get a nightly build to crash. So, I am holding off applying the fix to our upcoming alpha.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Turns out we need it for esr52 as well. I pushed commit c90a0868540a9771cc10bdc1cf91b8f6a8f37603 (on tor-broswser-52.0.2esr-7.0-2).

closed

moved to tpo/applications/tor-browser#21795 (closed)