Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#21795 closed defect (fixed)

Tor Browser is crashing on github.com on Windows

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Critical Keywords: TorBrowserTeam201704R, tbb-crash
Cc: arthuredelstein@…, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A user reported that Tor Browser on Windows is crashing reliably when going to https://help.github.com/categories/writing-on-github/. This happens with Tor Browser 6.5.1.

Child Tickets

Change History (12)

comment:1 Changed 2 years ago by cypherpunks

kidding?

comment:2 Changed 2 years ago by arthuredelstein

Cc: arthuredelstein@… added

comment:3 Changed 2 years ago by cypherpunks

https://help.github.com/assets/javascripts/application.js
Tor Browser with High Security is not affected, Win XP is not affected.
Is this the SSP in action?

comment:4 Changed 2 years ago by lolscreen

@gk I can confirm: tested on latest Tor Browser (6.5.1) security settings set to Low with Windows 7 32bits SP1.

comment:6 Changed 2 years ago by gk

Keywords: TorBrowserTeam201704 added; TorBrowserTeam201703 removed

Remmove remaining tickets over to April

comment:7 Changed 2 years ago by gk

Keywords: tbb-crash added

comment:8 Changed 2 years ago by gk

Cc: mcs brade added
Keywords: TorBrowserTeam201704R added; TorBrowserTeam201704 removed

I think I have a workaround that does not look awful: bug_21795 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_21795&id=fd67e2869611a961893a868fa0891cf4ded173eb). Please review.

comment:9 Changed 2 years ago by gk

Status: newneeds_review

comment:10 Changed 2 years ago by mcs

r=brade,r=mcs
This looks okay to us; I guess Mozilla may come up with a differemt fix but we can pick that up later.

comment:11 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Pushed as commit fd67e2869611a961893a868fa0891cf4ded173eb to tor-browser-45.8.0esr-6.5-2. It seems that esr52 is somehow not affected as I can't get a nightly build to crash. So, I am holding off applying the fix to our upcoming alpha.

comment:12 Changed 2 years ago by gk

Turns out we need it for esr52 as well. I pushed commit c90a0868540a9771cc10bdc1cf91b8f6a8f37603 (on tor-broswser-52.0.2esr-7.0-2).

Note: See TracTickets for help on using tickets.