Opened 3 years ago

Closed 2 years ago

#21797 closed defect (fixed)

Disable Firefox Telemetry experiments in Tor Browser

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, tbb-7.0-must-alpha, TorBrowserTeam201705R
Cc: fdsfgs@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor4

Description

We don't need any Telemetry experiments active in Tor Browser. Flipping the extperiments.* prefs should be enough for this.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by cypherpunks

toolkit.telemetry.enabled is currently false, but experiments.enabled is true.

Does this mean Tor Browser is currently sometimes performing experiments for Mozilla? Where can one read more about this?

comment:2 in reply to:  1 Changed 3 years ago by cypherpunks

Replying to cypherpunks:

toolkit.telemetry.enabled is currently false, but experiments.enabled is true.

Does this mean Tor Browser is currently sometimes performing experiments for Mozilla? Where can one read more about this?

It can. Read the source (c).
There are no experiments for release channel now (#13575 is separate). See https://telemetry-experiment.cdn.mozilla.net/manifest/v1/firefox/

comment:3 Changed 3 years ago by tokotoko

Cc: fdsfgs@… added

comment:4 Changed 2 years ago by gk

Keywords: tbb-7.0-must added

Adding tickets to our 7.0 ticket list

comment:5 Changed 2 years ago by gk

Keywords: tbb-7.0-must-alpha added; tbb-7.0-must removed

Moving tickets onto our alpha radar.

comment:6 Changed 2 years ago by gk

Keywords: TorBrowserTeam201705R added
Status: newneeds_review

bug_21797 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_21797&id=c56819cf6e7f9f394d2ce8553ccd77f7a6559644) has a proposed fix up for review. (Although, looking at the code it seems to me this is more of a defense-in-depth).

comment:7 Changed 2 years ago by brade

r=brade, r=mcs
Yes, this seems to be defense-in-depth.

comment:8 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

commit c56819cf6e7f9f394d2ce8553ccd77f7a6559644 has the fix (even though it got committed too early by mistake) on tor-browser-52.1.0esr-7.0-2. Turns out the bug number in the commit message is wrong. While not nice this is gone after the next rebase and squash.

Note: See TracTickets for help on using tickets.