Opened 7 months ago

Closed 4 weeks ago

#21800 closed defect (fixed)

test suite triggers Bug: Result does not fit in tor_timegm but does not fail

Reported by: weasel Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version: Tor: 0.2.9.10
Severity: Normal Keywords: 029-backport, 030-backport, 031-deferred-20170425
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

on 32bit archs like ia32 and armhf:

tortls/cert_is_valid: [forking] OK
tortls/context_init_one: [forking] OK
util/time: Mar 05 13:17:01.229 [warn] tor_timegm(): Bug: Result does not fit in tor_timegm (on Tor 0.2.9.10 )
Mar 05 13:17:01.229 [warn] tor_timegm(): Bug: Result does not fit in tor_timegm (on Tor 0.2.9.10 )
Mar 05 13:17:01.229 [warn] tor_timegm(): Bug: Result does not fit in tor_timegm (on Tor 0.2.9.10 )
OK
util/parse_http_time: Mar 05 13:17:01.229 [warn] tor_timegm(): Bug: Result does not fit in tor_timegm (on Tor 0.2.9.10 )
OK
util/config_line: OK
util/config_line_quotes: OK

[ from e.g. https://buildd.debian.org/status/fetch.php?pkg=tor&arch=i386&ver=0.2.9.10-1&stamp=1488719845&raw=0 ]

Child Tickets

Change History (12)

comment:1 Changed 7 months ago by weasel

So that's two issues here:
a) maybe hitting a Bug: warning in the test suite should cause a failure
b) the actual timegm() thing.

comment:2 Changed 7 months ago by nickm_mobile

Keywords: 029-backport 030-backport added
Milestone: Tor: 0.3.1.x-final

Is this 0.2.9 only, or also 0.3.0 and 0.3.1? I believe did your item (a) in one of the more recent branches already. (Could be wrong)

comment:3 Changed 7 months ago by weasel

It is also 0.3.0.x. cf. https://buildd.debian.org/status/fetch.php?pkg=tor&arch=i386&ver=0.3.0.4-rc-1&stamp=1488638110&raw=0

I don't have build logs with useful testsuite output for master on jenkins because we hide that by default :(

comment:5 Changed 6 months ago by nickm

Keywords: 031-deferred-20170425 added
Milestone: Tor: 0.3.1.x-finalTor: 0.3.2.x-final

Triage: batch-defer unowned items of priority Medium or lower to 0.3.2.

comment:6 Changed 4 weeks ago by nickm

Owner: set to nickm
Status: newaccepted

comment:7 Changed 4 weeks ago by nickm

Status: acceptedneeds_review

I think I've tracked these down. I suggest only fixing them in 0.3.2.

See branch bug21800.

comment:8 Changed 4 weeks ago by catalyst

Looks good, but I don't have a readily-accessible 32-bit system to test on.

comment:9 Changed 4 weeks ago by nickm

Status: needs_reviewmerge_ready

Me neither: I'll merge, wait for our CI, and close if it works out.

comment:10 Changed 4 weeks ago by nickm

We ran into a bug that I tried to fix with 512c57cff97c0533bbb56e6c41a1e3dca5fd9064 . Let's see if the CI tests become happier.

comment:11 Changed 4 weeks ago by nickm

Okay, it's passing again, but I still see a couple Result does not fit in tor_timegm warnings. Going to wait for more CI builders to finish, then analyze.

comment:12 Changed 4 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

Okay. This bug seems gone as of 230a33679814f3074c0ba43e42dc7b38b5342c10.

Note: See TracTickets for help on using tickets.