Opened 3 years ago

Last modified 10 months ago

#21810 new defect

Port rebind should not be performed after soft accounting limit reached

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.9.10
Severity: Normal Keywords: regression?, easy, 029-backport?, 032-unreached
Cc: rl1987 Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

A relay operator reports:

  • their relay had accounting set
  • it reached the soft limit and marked all connections for close
  • when the period ended, it estimated that it would be active for the entire period
  • then it attempted to rebind to ports, even though it had never closed the listeners

This appears to be a simple state management issue:
https://lists.torproject.org/pipermail/tor-relays/2017-March/012151.html

I don't think the issue is restricted to OpenBSD.

I don't know if it's a regression, and I don't know if it should be fixed in 0.3.0. Given how annoying and confusing it is, we should probably backport it.

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by nickm

Milestone: Tor: 0.3.0.x-finalTor: 0.3.2.x-final

comment:2 Changed 2 years ago by nickm

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Move some 0.3.2 items (fewer than I had expected for now) into Unspecified.

comment:3 Changed 10 months ago by rl1987

Cc: rl1987 added
Note: See TracTickets for help on using tickets.