Opened 15 months ago

Closed 7 months ago

Last modified 7 months ago

#21827 closed enhancement (fixed)

Add recommended_version to bridge details document

Reported by: cypherpunks Owned by: metrics-team
Priority: Medium Milestone: Onionoo-1.8.0
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Relays have a recommended_version flag, bridges should have it as well.

Child Tickets

Change History (6)

comment:1 Changed 15 months ago by karsten

Related comment from another ticket: "The reason is that the bridge authority does not recommend versions, so that we'd have to take version recommendations from relay network status consensuses and apply that to bridges. There may be other issues. But I see how this would be potentially useful. Please open an Onionoo ticket for this if you want this feature to be added to Onionoo."

comment:2 Changed 9 months ago by karsten

Summary: add recommended_version to bridge details documentAdd recommended_version to bridge details document

Capitalize summary.

comment:3 Changed 7 months ago by karsten

Status: newneeds_review

(I worked on all currently open (recommended) version related Onionoo tickets including this one: #22488, #23962, #21827, and #23544.)

This was relatively easy to build based on #22488 and #23962.

Please review the third commit edc796c in my tasks-22488-23962-21827-23544 branch together with specification changes in commit 75c7626 in my corresponding metrics-web branch.

comment:4 Changed 7 months ago by iwakeh

Status: needs_reviewmerge_ready

As remarked on #22488: tests and checks pass, spec changes describe the changes. The method name getRecommendedVersion is quite misleading - especially together with getVersion - as it returns a boolean not a version value, but as the method was introduced long ago this shouldn't halt a merge.

Maybe, the naming could be improved at some point?

Last edited 7 months ago by iwakeh (previous) (diff)

comment:5 in reply to:  4 Changed 7 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Replying to iwakeh:

As remarked on #22488: tests and checks pass, spec changes describe the changes.

Great, thanks for checking! Merged. Closing.

The method name getRecommendedVersion is quite misleading - especially together with getVersion - as it returns a boolean not a version value, but as the method was introduced long ago this shouldn't halt a merge.

Maybe, the naming could be improved at some point?

Sure, we can improve the naming anytime. I just created #24419 for this.

comment:6 Changed 7 months ago by iwakeh

Milestone: Onionoo-1.8.0

This will be part of the next release.

Note: See TracTickets for help on using tickets.