Changes between Version 1 and Version 2 of Ticket #21827, comment 4


Ignore:
Timestamp:
Nov 26, 2017, 7:25:36 PM (16 months ago)
Author:
iwakeh
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21827, comment 4

    v1 v2  
    1 As remarked on #22488: tests and checks pass, spec changes describe the changes. The method name `getRecommendedVersion` is quite misleading - especially together with `getVersion` - as it returns a boolean, but as the method was introduced long ago this shouldn't halt a merge.
     1As remarked on #22488: tests and checks pass, spec changes describe the changes. The method name `getRecommendedVersion` is quite misleading - especially together with `getVersion` - as it returns a boolean not a version value, but as the method was introduced long ago this shouldn't halt a merge.
    22
    33Maybe, the naming could be improved at some point?