Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2184 closed defect (fixed)

Allocate enough memory for extra-info descriptor

Reported by: karsten Owned by:
Priority: Medium Milestone:
Component: Core Tor/Tor Version: Tor: 0.2.2.17-alpha
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When we added directory byte histories in db94b7f, we didn't extend the extra-info descriptor size. We allocate 8332 bytes for bandwidth histories in rep_hist_get_bandwidth_lines(), but only 8192 bytes for the total extra-info descriptor in router_rebuild_descriptor(). We should extend this size to 16384 bytes. Bug found by boboper.

See branch extrainfosize in my public repository that should be merged into maint-0.2.2 and master.

Child Tickets

Change History (4)

comment:1 Changed 9 years ago by karsten

Nick asked on #tor-dev by how much we increased the average extra-info descriptor size with the directory byte statistics. Here are some statistics on the number of additional bytes required by directory byte statistics:

 Min.   : 187
 1st Qu.: 240
 Median : 650
 Mean   : 788
 3rd Qu.:1181
 Max.   :2009

So, on average, we add 788 bytes per extra-info descriptor.

comment:2 Changed 9 years ago by karsten

Resolution: fixed
Status: newclosed

Fixed by cec21652a7c939d1112591347e35c0815de63f93.

comment:3 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:4 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.