Opened 6 months ago

Closed 6 months ago

#21842 closed enhancement (implemented)

Remove tor-checkkey

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: ahf Actual Points: 0
Parent ID: Points:
Reviewer: ahf Sponsor:

Description

We currently build a tor-checkkey binary in src/tools. It extracts and prints the modulus from a PEM-encoded RSA public key.

Long ago, we added it on order to help detect and clean up the effects of the Debian OpenSSL RNG bug (CVE-2008-0166). But that's nearly a decade ago; maybe we can let this code get removed.

Child Tickets

Change History (8)

comment:1 Changed 6 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 6 months ago by nickm

Actual Points: 0
Status: acceptedneeds_review

See branch ticket21842 in my public repository.

comment:3 Changed 6 months ago by nickm

Type: defectenhancement

comment:4 Changed 6 months ago by cypherpunks

Status: needs_reviewneeds_revision

There is a typo in the changes file

-    - We've remove the tor-checkkey tool from src/tools. Long ago, we
+    - We've removed the tor-checkkey tool from src/tools. Long ago, we

And there are some remaining references to tor-checkkey

.gitignore:202:/src/tools/tor-checkkey
.gitignore:207:/src/tools/tor-checkkey.exe
src/common/crypto.c:470:/** Helper, used by tor-checkkey.c and tor-gencert.c.  Return the RSA from a

comment:5 Changed 6 months ago by nickm

Status: needs_revisionneeds_review

Branch updated. I've left the .gitignore stuff alone, since it's annoying to get a bunch of warnings about stale binaries when you switch back and forth between branches.

comment:6 Changed 6 months ago by ahf

Status: needs_reviewmerge_ready

Looks good to me. Only able to spot the leftovers that is already mentioned in .gitignore. I guess those should be cleaned up at some point in the future.

comment:7 Changed 6 months ago by ahf

Cc: ahf added
Reviewer: ahf

comment:8 Changed 6 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.