Opened 2 years ago

Closed 23 months ago

#21843 closed defect (wontfix)

Switching from `make alpha` to `make nightly` doesn't work

Reported by: tom Owned by: tbb-team
Priority: Low Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-gitian
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Switching from make alpha to make nightly gives this error:

updating: mac-langpacks/pt-BR.xpi (deflated 10%)
You are not currently on a branch.
Please specify which branch you want to merge with.
See git-pull(1) for details.

    git pull <remote> <branch>

Makefile:97: recipe for target 'prep-nightly' failed
make: *** [prep-nightly] Error 1

This can be traced to this:
https://gitweb.torproject.org/builders/tor-browser-bundle.git/tree/gitian/fetch-inputs.sh#n258

Because make alpha checked out a tag, git pull fails. We can detect a checkout tag with something like git status | grep "HEAD detached" and behave more intelligently.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by gk

Keywords: tbb-gitian added

comment:2 Changed 23 months ago by gk

Resolution: wontfix
Status: newclosed

We are switching to rbm where those issues are no concern (anymore). We won't fix those.

Note: See TracTickets for help on using tickets.