Opened 14 months ago

Closed 5 months ago

Last modified 5 months ago

#21847 closed enhancement (fixed)

Update copy for security slider to be consistent with the mobile experience

Reported by: isabela Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-usability, tbb-security-slider, TorBrowserTeam201712R, GeorgKoppen201712
Cc: arthuredelstein, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We just finished our work with building the security slider experience for Orfox. We are very happy with the results we got from our user research on that project.

Since the slider on desktop now also has 3 options instead of 4. The UX team would like to suggest that we also use the same copy used for Orfox experience.

We hope to continue improve our user experience and this copy might change in the future as a result of that. In case of that happen we will make sure to keep the experience consistent on all platforms.

That new copy would be:

The results of our efforts! Both Orfox and Tor Browser have agreed to adopt these changes.

Standard 

All Tor Browser and website features are enabled. 

Safer

Disables website features that are often dangerous, causing some sites will lose functionality. 

At this cautious setting: 
* JavaScript is disabled on non-HTTPS sites.
* Some fonts and math symbols are disabled.
* Audio and video (HTML5 media) are tap-to-play. 

Learn more  (link to https://tb-manual.torproject.org/en-US/security-slider.html)

Safest

Only allows website features required for static sites and basic services. These changes affect images, media, and scripts. 

At the strict security setting: 
* JavaScript is disabled by default on all sites. 
* Some fonts, icons, math symbols and images are disabled.
* Audio and video (HTML5 media) are tap-to-play. 

Learn more  (link to https://tb-manual.torproject.org/en-US/security-slider.html)

Child Tickets

Attachments (1)

torbutton-1.9.8.3_21847.xpi (893.4 KB) - added by gk 5 months ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 14 months ago by gk

Keywords: tbb-usability added
Type: defectenhancement

comment:2 Changed 12 months ago by gk

Keywords: tbb-security-slider added

comment:3 Changed 10 months ago by arthuredelstein

Cc: arthuredelstein added

comment:4 Changed 10 months ago by gk

Keywords: TorBrowserTeam201709 added

comment:5 Changed 8 months ago by gk

Keywords: TorBrowserTeam201710 added; TorBrowserTeam201709 removed

Items for October 2017

comment:6 Changed 6 months ago by gk

Keywords: TorBrowserTeam201711 added; TorBrowserTeam201710 removed

Moving tickets over to November.

comment:7 Changed 6 months ago by gk

Keywords: GeorgKoppen201711 added

comment:8 Changed 6 months ago by gk

Moving tickets to December 2017

comment:9 Changed 6 months ago by gk

Keywords: TorBrowserTeam201712 added; TorBrowserTeam201711 removed

Moving tickets to December 2017, for realz.

comment:10 Changed 6 months ago by gk

Keywords: GeorgKoppen201712 added; GeorgKoppen201711 removed

Moving my tickets to December.

comment:11 Changed 5 months ago by teor

Can we do some minor English copy editing here?

"causing some sites will lose functionality"
"causing some sites to lose functionality"

And is there any reason why these headings are different?

"At this cautious setting:"
"At the strict security setting:"

If not, let's use:

"At the cautious security setting:"
"At the strict security setting:"

Or maybe for both:

"At this setting:"

comment:12 in reply to:  11 Changed 5 months ago by gk

Replying to teor:

Can we do some minor English copy editing here?

Sure.

"causing some sites will lose functionality"
"causing some sites to lose functionality"

That's actually already fixed in the mobile strings. So it might be a copy and paste error or older strings which are shown in comment:description.

And is there any reason why these headings are different?

"At this cautious setting:"
"At the strict security setting:"

If not, let's use:

"At the cautious security setting:"
"At the strict security setting:"

Or maybe for both:

"At this setting:"

We have

safer_list_label = At this safer setting
safest_list_label = At the safest setting

in the mobile strings. I think I'll use "At the safer setting" and "At the safest setting" instead assuming safer_list_label has a typo.

comment:13 Changed 5 months ago by gk

Cc: mcs brade added
Keywords: TorBrowserTeam201712R added; TorBrowserTeam201712 removed
Status: newneeds_review

bug_21847 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_21847&id=e0a8b16619c691ff44488c9c5b003875f62960ca) in my torbutton repo has a patch for review.

I was tempted to follow the "HTML-ization" of the dialog by adding the bullets but I then thought this is still XUL and mixing both might look weird in the end given that the remaining UI has basically no HTML elements. This I left the bullets out (but the result is still list-like).

I attached an .xpi which should be working to test this in en-US bundles.

Changed 5 months ago by gk

Attachment: torbutton-1.9.8.3_21847.xpi added

comment:14 Changed 5 months ago by mcs

The changes look fine to me, except we should replace the word "tap" with "click" for desktop. I think it is only the torbutton.prefs.sec_tap_to_play_media entity which needs to be updated.

We should make sure that any minor text changes flow back to mobile (other than "tap" -> "click").

Also, I wanted to compare to the Orfox interface but I could not figure out how to open the security slider on Android. Either it is not there or I cannot find it (but I am pretty sure I have seen it in the past). I tried with the version from Google Play (1.4rc3?) as well as this release candidate:
https://github.com/guardianproject/Orfox/releases/tag/Fennec-52.2.0esr%2FTorBrowser-7.0-1%2FOrfox-1.4.1-RC-1

comment:15 in reply to:  14 Changed 5 months ago by gk

Replying to mcs:

The changes look fine to me, except we should replace the word "tap" with "click" for desktop. I think it is only the torbutton.prefs.sec_tap_to_play_media entity which needs to be updated.

Good point. Should be fixed in bug_21847_v2 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_21847_v2&id=678c3548779a7316c96c79295f3e85efeee05fb7). Please have a look again.

We should make sure that any minor text changes flow back to mobile (other than "tap" -> "click").

I'll open a follow-up bug once we are done here.

Also, I wanted to compare to the Orfox interface but I could not figure out how to open the security slider on Android. Either it is not there or I cannot find it (but I am pretty sure I have seen it in the past). I tried with the version from Google Play (1.4rc3?) as well as this release candidate:
https://github.com/guardianproject/Orfox/releases/tag/Fennec-52.2.0esr%2FTorBrowser-7.0-1%2FOrfox-1.4.1-RC-1

Good question. I currently don't have a mobile device to test that. What I used instead was using the screenshot on https://blog.torproject.org/blog/upping-support-mobile-browsing.

comment:16 Changed 5 months ago by mcs

The followup patch looks good to me.
I did notice a small issue today when I ran with the new code on macOS: when the Security Settings window first opens, nthe "Learn More" link has the keyboard focus. I suppose that is just default XUL behavior (set focus to the first element that can have a keyboard focus), but it looks a little strange because macOS draws a box around the link. If you think this is worth fixing, the following addition to torbutton_init_security_ui() fixes it:

  let okBtn = document.documentElement.getButton("accept");
  if (okBtn)
    okBtn.focus();

comment:17 in reply to:  16 Changed 5 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to mcs:

The followup patch looks good to me.
I did notice a small issue today when I ran with the new code on macOS: when the Security Settings window first opens, nthe "Learn More" link has the keyboard focus. I suppose that is just default XUL behavior (set focus to the first element that can have a keyboard focus), but it looks a little strange because macOS draws a box around the link. If you think this is worth fixing, the following addition to torbutton_init_security_ui() fixes it:

  let okBtn = document.documentElement.getButton("accept");
  if (okBtn)
    okBtn.focus();

Thanks, this is included in commit 0e9fe510277aeb8617f9de73d24b85436479f129 on master now. The follow-up ticket for getting the improvements made here back to mobile is #24653.

Last edited 5 months ago by gk (previous) (diff)
Note: See TracTickets for help on using tickets.