Vidalia can't handle blank CountrySummary= arg in Bridge History

Error when clicking the "who has used my bridge" link on relay set-up, sharing menu. Says

Vidalia was unable to retrieve your bridge's usage history.

and

Tor returned an improperly formatted response when Vidalia requested your bridge's usage history.

and on show details

eg.Tor returned an improperly formatted response when Vidalia requested your bridge's usage history.

I'm a non hacker, just wanting to help.

Trac:
Username: say.hello.to.anna

added component::archived/vidalia owner::chiiph priority::medium reporter::say.hello.to.anna resolution::fixed status::closed type::defect labels

what combination of Tor and Vidalia versions are you using?

Trac:
Description: Error when clicking the "who has used my bridge" link on relay set-up, sharing menu. Says

Vidalia was unable to retrieve your bridge's usage history.

and

Tor returned an improperly formatted response when Vidalia requested your bridge's usage history.

and on show details

eg.Tor returned an improperly formatted response when Vidalia requested your bridge's usage history.

I'm a non hacker, just wanting to help.

to

Error when clicking the "who has used my bridge" link on relay set-up, sharing menu. Says

Vidalia was unable to retrieve your bridge's usage history.

and

Tor returned an improperly formatted response when Vidalia requested your bridge's usage history.

and on show details

eg.Tor returned an improperly formatted response when Vidalia requested your bridge's usage history.

I'm a non hacker, just wanting to help.

I got into this error too.

And I'm using the most recently test version of tor+vidalia bundle of 0.2.2.17-0.2.10.

Actually, even the stable version has this bug too. I had never got the using info successfully.

Trac:
Username: lonelicloud

Trac:
Username: akwala

screenshot of error

Trac:
Username: akwala

Me too...

System: Ubuntu 10.10 amd64 Vidalia: 0.2.10 Tor: 0.2.2.21-alpha-1~maverick+1

Trac:
Username: akwala

Looks like Vidalia can't handle a blank CountrySummary argument?

Thanks, the screenshot was extremely helpful! The bug is in Vidalia, src/vidalia/config/ServerPage.cpp, where an empty CountrySummary leads to the described error message.

This is a Vidalia bug, not an issue with Tor, as the Tor specification explicitly states that an empty list of CountrySummary is possible.

Trac:
0001-Tolerate-empty-responses-to-a-clients-seen-query.patch

There's a trivial patch. It doesn't make the resulting window very pretty (the window is just empty, some text saying "hey sorry, no bridges, go spread your bridge manually/check connectivity/maybe china blocked it, etc" would be nice, tho it does seem kind of optional.

Someone should also figure out why the foreach body is actually reached at all, and if maybe pair is simply empty or something that can be detected earlier on.

Trac:
Status: new to needs_review

Trac:
Keywords: Bridge Histroy deleted, N/A added
Actualpoints: N/A to N/A
Summary: Bridge Histroy Error to Vidalia can't handle blank CountrySummary= arg in Bridge History
Actualpointsdone: N/A to N/A
Pointsdone: N/A to N/A
Points: N/A to N/A

Trac:
ticket-2186.patch

Meh, Sebastian's patch kinda sucks for the reasons he noted above. There's already code for a dialog box in that with the "hey sorry, no bridge users yet" message, so why not reuse it rather than displaying an empty user table? In theory, I like the patch I attached better, but I haven't been able to reproduce the blank CountrySummary line (I didn't try too hard) so I haven't been able to test it. If someone who can reproduce the black CountrySummary wants to give it a try, that'd be handy.

And the answer to the mystery noted in your patch and comment above is because QString's default split behavior is QString::KeepEmptyParts.

The patch was committed. Closing.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed