Opened 2 years ago

Closed 2 years ago

#21861 closed defect (fixed)

Make sure new mDNS code is disabled in ESR 52-based Tor Browsers

Reported by: gk Owned by: gk
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, TorBrowserTeam201705R, tbb-7.0-must
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor4

Description

There is new mDNS code we don't want to have in

/dom/presentation/provider/MulticastDNSDeviceProvider.cpp
netwerk/dns/mdns/libmdns/fallback/MulticastDNS.jsm

Child Tickets

Change History (8)

comment:1 Changed 2 years ago by gk

Priority: MediumHigh

This is higher prio.

comment:2 Changed 2 years ago by arthuredelstein

(Looking for potential proxy bypasses. See mikeperry's observations in ticket:21625#comment:3.)

comment:3 Changed 2 years ago by gk

Keywords: TorBrowserTeam201705 added; TorBrowserTeam201704 removed

Moving our tickets to May 2017.

comment:4 Changed 2 years ago by gk

Keywords: tbb-7.0-must added; tbb-7.0-must-alpha removed

We are beyond the alpha testing. Moving tickets for tbb-7.0-must.

comment:5 Changed 2 years ago by gk

Cc: tbb-team added
Owner: changed from tbb-team to gk
Status: newassigned

comment:6 Changed 2 years ago by gk

Keywords: TorBrowserTeam201705R added; TorBrowserTeam201705 removed
Status: assignedneeds_review

bug_21861_v2 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_21861_v2&id=e1216ec38f9a2a544763bde44c758275c1f2cb78) has a fix for this bug. I built with it for all three platforms in our Gitian environment and nothing blew up. Although, the Linux build did not want to compile first. I tried with the same patch locally and later on in Gitian as well and things worked then. Thus, I guess the first build failure was unrelated (the log was not really clear about why the build failed).

comment:7 Changed 2 years ago by mcs

r=mcs
This looks okay to me.

comment:8 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, applied to tor-browser-52.1.1esr-7.0-1 and tor-browser-52.1.0esr-7.0-2 (commit 0da4a7dc08b0c9b4fa6c454da210e8c3c3ae6197 and a979fd68b78a17814bde3544b7d8896c6089cf6e).

Note: See TracTickets for help on using tickets.