Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#21865 closed defect (fixed)

Update security slider to take JIT preference changes into account

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, tbb-security-slider, TorBrowserTeam201704R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For a while there were different JIT prefs for content and chrome. That changed with bug 939562. We need to adapt the slider to reflect that.

Suggested prefs for disabling now are

javascript.options.ion
javascript.options.baselinejit
javascript.options.native_regexp

asm.js is already off due to other reasons (#19417)

Child Tickets

Change History (8)

comment:1 Changed 2 years ago by cypherpunks

So since ESR31 we have just been switching off optimizations which don't exist. Unbelievable :)

comment:2 Changed 2 years ago by gk

Keywords: TorBrowserTeam201704R added; TorBrowserTeam201704 removed
Status: newneeds_review

comment:3 Changed 2 years ago by cypherpunks

-   "javascript.options.typeinference" :        [,  false, false, false, true ],

comment:4 Changed 2 years ago by arthuredelstein

This patch looks good, perhaps with the comment:3 suggestion. Should we update the text of torbutton.prefs.sec_jit_desc_tooltip as well?

comment:5 Changed 2 years ago by gk

Why should we remove javascript.options.typeinference? Looking at JIT code it seems still to be there.
Updating the tooltip and removing "asm.js" and adding "native_regexp" seems to be a good idea.

Last edited 2 years ago by gk (previous) (diff)

comment:6 in reply to:  5 Changed 2 years ago by gk

Replying to gk:

Why should we remove javascript.options.typeinference? Looking at JIT code it seems still to be there.
Updating the tooltip and removing "asm.js" and adding "native_regexp" seems to be a good idea.

I stand corrected. I am not sure anymore why I thought we still have this pref available. Looking again convinces me that it is indeed gone. Arthur pointed me to https://bugzilla.mozilla.org/show_bug.cgi?id=972817 which puts additional weight on the "is-gone-theory". I'll update the patch accordingly.

comment:7 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks all. I pushed a fix to master (commit cb73494b177f0dcb595920090a81af5621083f8d) taking the review feedback into account.

comment:8 Changed 2 years ago by cypherpunks

If the idea is to disable JIT entirely, then we should also think about disabling Type Inference.

Note: See TracTickets for help on using tickets.