Opened 2 years ago

Closed 2 years ago

#21868 closed defect (fixed)

Code landed after FIREFOX_52_0_2esr_RELEASE breaks Tor Browser build for Windows

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: ff52-esr, TorBrowserTeam201704, GeorgKoppen201704, tbb-7.0-must-alpha
Cc: tom, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor4

Description

Building ESR 52 with mingw-w64 at least is broken using https://hg.mozilla.org/releases/mozilla-esr52/rev/e8651b7e41c8. Doing so with https://hg.mozilla.org/releases/mozilla-esr52/rev/afa66bcf9203 (FIREFOX_52_0_2esr_RELEASE) is still fine.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by cypherpunks

Yep, just another one buggy esr :) Will be fixed by 52.2 ;)
https://bugzilla.mozilla.org/show_bug.cgi?id=1299500#c35

comment:2 in reply to:  1 Changed 2 years ago by tom

Replying to cypherpunks:

Yep, just another one buggy esr :) Will be fixed by 52.2 ;)
https://bugzilla.mozilla.org/show_bug.cgi?id=1299500#c35

I opened https://bugzilla.mozilla.org/show_bug.cgi?id=1353765 for this

comment:3 Changed 2 years ago by arthuredelstein

Cc: arthuredelstein added

comment:4 Changed 2 years ago by gk

Status: newneeds_review

I took tjr's patch for bug 1353765 although it is not clear whether it is still needed. Commit db07e42c13b82aa62a6132be92974aca371546ac on tor-browser-52.0.2esr-7.0-2 has it.

comment:5 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

And done.

Note: See TracTickets for help on using tickets.