Opened 2 years ago

Closed 2 years ago

#21869 closed enhancement (implemented)

Labeled storage backend for consensus docs and diffs

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: 2
Parent ID: #21647 Points: 2
Reviewer: Sponsor: Sponsor4

Description

As part of #21647, we need a way to store consensus documents and consensus diffs persistently. The storagedir backend is mostly there, but it lacks a way to store metadata, or to manage reading/freeing/deleting documents on demand.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 2 years ago by nickm

Milestone: Tor: 0.3.1.x-final
Sponsor: Sponsor4
Status: acceptedneeds_review

Please see branch 'storage_labeled' in my public repository.

Also available to review in gitlab at https://gitlab.com/nickm_tor/tor/merge_requests/15

comment:3 Changed 2 years ago by ahf

Status: needs_reviewneeds_revision

Overall it looks very good. I've added a couple of comments in the GL merge request.

comment:4 Changed 2 years ago by nickm

I've added extra commits to resolve those issues. Better now?

comment:5 Changed 2 years ago by nickm

Resolution: implemented
Status: needs_revisionclosed

I've squashed and merged; but please let me know if there are any other changes you'd like.

Note: See TracTickets for help on using tickets.