#21875 closed defect (fixed)

Modal dialogs are maximized in ESR52 nightly builds

Reported by: gk Owned by: arthuredelstein
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: ff52-esr, tbb-7.0-must-alpha, TorBrowserTeam201704R
Cc: arthuredelstein, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Somewhat surprisingly all modal dialogs are getting maximized now in our ESR 52 nightly builds. I recall doing (and using) a pre-nightly build based on ESR52 a while ago which does not have this "feature". We should investigate what has regressed and fix the issue for the alpha

Child Tickets

Change History (11)

comment:1 Changed 19 months ago by gk

Preliminary nightly builds are here: https://people.torproject.org/~gk/testbuilds/tbb-nightly/. We had some gitian issues with the OS X ones. We are redoing those and have them ready for the announcement on tbb-dev.

Arthur: Can you take that one? It might be related to the backported window resizing patch? (Interestingly ESR52 seems to fix #20905 for me).

comment:2 Changed 19 months ago by cypherpunks

It is tracking on BMO, backported, has this "feature" and fixes #20905. Where are you, gk? ;))

comment:3 Changed 19 months ago by gk

I am here. To make it a bit more obvious what "It is tracking on BMO" means: https://bugzilla.mozilla.org/show_bug.cgi?id=1352305 looks very much like the same issue.

comment:4 in reply to:  3 Changed 19 months ago by gk

Replying to gk:

I am here. To make it a bit more obvious what "It is tracking on BMO" means: https://bugzilla.mozilla.org/show_bug.cgi?id=1352305 looks very much like the same issue.

I guess we could try some builds backporting this patch and see whether that fixes our problem (and does not open new issues).

comment:5 Changed 19 months ago by cypherpunks

Whether and where to write tbb-nightly review?

comment:6 in reply to:  5 ; Changed 19 months ago by gk

Replying to cypherpunks:

Whether and where to write tbb-nightly review?

Not sure what you mean by "review", but if you want to report bugs please do so in this bug tracker by opening one ticket per issue. Thanks.

comment:7 in reply to:  6 Changed 19 months ago by cypherpunks

Replying to gk:

Replying to cypherpunks:

Whether and where to write tbb-nightly review?

Not sure what you mean by "review", but if you want to report bugs please do so in this bug tracker by opening one ticket per issue. Thanks.

I meant discussion-style ticket, like #20680, from which decisions about opening new tickets were made.

comment:8 Changed 19 months ago by arthuredelstein

Owner: changed from tbb-team to arthuredelstein
Status: newaccepted

comment:9 Changed 19 months ago by arthuredelstein

I cherry-picked Tim's two patches for https://bugzilla.mozilla.org/show_bug.cgi?id=1352305 on top of our latest tor-browser alpha branch. I ran the mochitest and also tested manually with tor-launcher and the implementation patch seems to fix the problem. So I would recommend including them in the alpha.

https://github.com/arthuredelstein/tor-browser/commits/21875

comment:10 Changed 19 months ago by arthuredelstein

Keywords: TorBrowserTeam201704R added; TorBrowserTeam201704 removed
Status: acceptedneeds_review

comment:11 Changed 19 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Included in tor-browser-52.0.2esr-7.0-2 as commit 9ee872b57e55ae672a30f087cf55bccef18f3646 and e761b3ca2087275c165fb67b7f876a55286d47dd.

Note: See TracTickets for help on using tickets.