Modal dialogs are maximized in ESR52 nightly builds
Somewhat surprisingly all modal dialogs are getting maximized now in our ESR 52 nightly builds. I recall doing (and using) a pre-nightly build based on ESR52 a while ago which does not have this "feature". We should investigate what has regressed and fix the issue for the alpha
Activity
Preliminary nightly builds are here: https://people.torproject.org/~gk/testbuilds/tbb-nightly/. We had some gitian issues with the OS X ones. We are redoing those and have them ready for the announcement on tbb-dev.
Arthur: Can you take that one? It might be related to the backported window resizing patch? (Interestingly ESR52 seems to fix #20905 (moved) for me).
It is tracking on BMO, backported, has this "feature" and fixes #20905 (moved). Where are you, gk? ;))
-
I am here. To make it a bit more obvious what "It is tracking on BMO" means: https://bugzilla.mozilla.org/show_bug.cgi?id=1352305 looks very much like the same issue.
-
Replying to gk:
I am here. To make it a bit more obvious what "It is tracking on BMO" means: https://bugzilla.mozilla.org/show_bug.cgi?id=1352305 looks very much like the same issue.
I guess we could try some builds backporting this patch and see whether that fixes our problem (and does not open new issues).
-
Replying to cypherpunks:
Whether and where to write tbb-nightly review?
Not sure what you mean by "review", but if you want to report bugs please do so in this bug tracker by opening one ticket per issue. Thanks.
Replying to gk:
Replying to cypherpunks:
Whether and where to write tbb-nightly review?
Not sure what you mean by "review", but if you want to report bugs please do so in this bug tracker by opening one ticket per issue. Thanks. I meant discussion-style ticket, like #20680 (moved), from which decisions about opening new tickets were made.
I cherry-picked Tim's two patches for https://bugzilla.mozilla.org/show_bug.cgi?id=1352305 on top of our latest tor-browser alpha branch. I ran the mochitest and also tested manually with tor-launcher and the implementation patch seems to fix the problem. So I would recommend including them in the alpha.
https://github.com/arthuredelstein/tor-browser/commits/21875