Opened 3 years ago

Closed 3 years ago

#21879 closed defect (fixed)

OSX: default bookmarks not used

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, tbb-7.0-must-alpha, TorBrowserTeam201705R
Cc: brade, gk, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Our Tor Project bookmarks are not used by default in the ESR52-bssed TB nightly builds (I saw this problem on OSX with the builds mentioned here: comment:1:ticket:21875).

Although our bookmarks.html file is included in browser/omni.ja, it seems to be ignored. Maybe ESR52 uses a new mechanism for configuring the default bookmarks.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by arthuredelstein

I just checked this on
https://people.torproject.org/~boklm/builds/7.0a3-build4/tor-browser-linux64-7.0a3_en-US.tar.xz
and the bookmarks are present. Maybe this is OS X specific?

comment:2 Changed 3 years ago by mcs

Summary: default bookmarks not usedOSX: default bookmarks not used

Yes, it is OSX-specific. The mechanism that Firefox uses when creating a new profile (which only happens on OSX with Tor Browser) must have changed.

comment:3 Changed 3 years ago by gk

Keywords: TorBrowserTeam201705 added

Moving more tickets on our May 2015 radar.

comment:4 Changed 3 years ago by mcs

Cc: gk arthuredelstein added
Owner: changed from tbb-team to mcs
Status: newassigned

comment:5 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201705R added; TorBrowserTeam201705 removed
Status: assignedneeds_review

Mozilla changed the location of the default bookmarks within browser/omni.ja and also added them to the language packs. Here is a patch:
https://gitweb.torproject.org/user/brade/tor-browser-bundle.git/commit/?h=bug21879-01&id=57f088b981a0292d5370b3c56c6d7e5a18f95aca

comment:6 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, thanks. Applied to master as commit 57f088b981a0292d5370b3c56c6d7e5a18f95aca.

Note: See TracTickets for help on using tickets.