OSX: default bookmarks not used

Our Tor Project bookmarks are not used by default in the ESR52-bssed TB nightly builds (I saw this problem on OSX with the builds mentioned here: comment:1:ticket:21875).

Although our bookmarks.html file is included in browser/omni.ja, it seems to be ignored. Maybe ESR52 uses a new mechanism for configuring the default bookmarks.

added TorBrowserTeam201705R component::applications/tor browser ff52-esr owner::mcs priority::medium resolution::fixed severity::normal status::closed tbb-7.0-must-alpha type::defect labels

I just checked this on https://people.torproject.org/~boklm/builds/7.0a3-build4/tor-browser-linux64-7.0a3_en-US.tar.xz and the bookmarks are present. Maybe this is OS X specific?

Yes, it is OSX-specific. The mechanism that Firefox uses when creating a new profile (which only happens on OSX with Tor Browser) must have changed.

Trac:
Summary: default bookmarks not used to OSX: default bookmarks not used

Moving more tickets on our May 2015 radar.

Trac:
Keywords: N/A deleted, TorBrowserTeam201705 added

Trac:
Status: new to assigned
Owner: tbb-team to mcs
Cc: brade to brade, gk, arthuredelstein

Mozilla changed the location of the default bookmarks within browser/omni.ja and also added them to the language packs. Here is a patch: https://gitweb.torproject.org/user/brade/tor-browser-bundle.git/commit/?h=bug21879-01&id=57f088b981a0292d5370b3c56c6d7e5a18f95aca

Trac:
Status: assigned to needs_review
Keywords: TorBrowserTeam201705 deleted, TorBrowserTeam201705R added

Looks good, thanks. Applied to master as commit 57f088b981a0292d5370b3c56c6d7e5a18f95aca.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #22044 (moved)

mentioned in issue #27466 (moved)

mentioned in issue #28940 (moved)

mentioned in issue #31942 (moved)

moved to tpo/applications/tor-browser#21879 (closed)

mentioned in issue tpo/applications/tor-browser#31942 (closed)