Opened 3 years ago

Closed 3 years ago

#21885 closed defect (fixed)

SVG is not disabled in Tor Browser based on ESR52

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, tbb-7.0-must-alpha, tbb-torbutton, tbb-security-slider, TorBrowserTeam201704R
Cc: arthuredelstein, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor4

Description

SVG is not disabled anymore on our highest security level in ESR 52-based nightly builds. I.e. https://upload.wikimedia.org/wikipedia/commons/6/6c/Trajans-Column-lower-animated.svg renders in my Tor Browser.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by gk

Keywords: tbb-torbutton tbb-security-slider TorBrowserTeam201704R added
Status: newneeds_review

We did not backport Mozilla's SVG patch which is using svg.disabled but switched Torbutton code to observe that one already. Going back to svg.in-content.enabled fixes that. bug_21885 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_21885&id=de57f2c4ef125ca1334e83efa1949770a87e7c38) in my repo has a fix up for review.

Last edited 3 years ago by gk (previous) (diff)

comment:2 Changed 3 years ago by mcs

r=brade, r=mcs
Looks good to us.

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, fixed with de57f2c4ef125ca1334e83efa1949770a87e7c38 on master.

Note: See TracTickets for help on using tickets.