Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21887 closed defect (fixed)

Error pages are broken in TBB ff52 nightly with security slider being on "Medium" or "High"

Reported by: blockflare Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, TorBrowserTeam201704R
Cc: gk, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Go to a non-existent website http://nonexisssstentwebsite.com/

Or go to a website that doesn't support HTTPS with HTTPS: https://mysite.com/ (the "Go Back" button works, and the "Advanced" one doesn't)

Child Tickets

Attachments (2)

1.png (23.4 KB) - added by blockflare 3 years ago.
Screenshot for broken error page
2.png (23.4 KB) - added by blockflare 3 years ago.
Screenshot of broken error page

Download all attachments as: .zip

Change History (17)

comment:1 in reply to:  description ; Changed 3 years ago by cypherpunks

Replying to blockflare:

Go to a non-existent website http://nonexisssstentwebsite.com/

Unable to connect
Firefox can’t establish a connection to the server at nonexisssstentwebsite.com.
...
Try Again

What is broken? "Firefox" instead of "Tor Browser"?

Or go to a website that doesn't support HTTPS with HTTPS: https://mysite.com/ (the "Go Back" button works, and the "Advanced" one doesn't)

The same.

[04-07 11:20:20] Torbutton INFO: controlPort >> 650 STREAM 256 CLOSED 51 mysite.com:443 REASON=END REMOTE_REASON=CONNECTREFUSED

Changed 3 years ago by blockflare

Attachment: 1.png added

Screenshot for broken error page

Changed 3 years ago by blockflare

Attachment: 2.png added

Screenshot of broken error page

comment:2 in reply to:  1 Changed 3 years ago by blockflare

Replying to cypherpunks:

Replying to blockflare:

Go to a non-existent website http://nonexisssstentwebsite.com/

Unable to connect
Firefox can’t establish a connection to the server at nonexisssstentwebsite.com.
...
Try Again

What is broken? "Firefox" instead of "Tor Browser"?

Not what I had in mind, through that's a good catch :)

Look at the screenshots I included. (Also this was tested on Debian 64)

comment:3 Changed 3 years ago by cypherpunks

You see buttons from Secure connection error page. Of course, they are not actionable.
This is a regression of esr52 fix for #8842.
Confirmed with STR from that ticket.

comment:4 Changed 3 years ago by gk

Status: newneeds_information

blockflare: this does not happen with the security slider set to "low", right?

comment:5 Changed 3 years ago by gk

Keywords: tbb-usability-website added

Interestingly the error page is actually a different one with "low", huh.

comment:6 in reply to:  4 Changed 3 years ago by blockflare

Replying to gk:

blockflare: this does not happen with the security slider set to "low", right?

Yes, only Medium and High are affected.

comment:7 Changed 3 years ago by gk

Keywords: tbb-security-slider added
Status: needs_informationassigned
Summary: Error pages are broken in TBB ff52 nightlyError pages are broken in TBB ff52 nightly with security slider not being on "Low"

comment:8 Changed 3 years ago by gk

Summary: Error pages are broken in TBB ff52 nightly with security slider not being on "Low"Error pages are broken in TBB ff52 nightly with security slider being on "Medium" or "High"

comment:9 Changed 3 years ago by cypherpunks

Allow JS on about:neterror?

comment:10 in reply to:  9 Changed 3 years ago by blockflare

Replying to cypherpunks:

Allow JS on about:neterror?

Indeed, adding about:neterror in the NoScript whitelist solves the problem in both Medium and High.

comment:11 Changed 3 years ago by gk

Keywords: TorBrowserTeam201704R added
Status: assignedneeds_review

comment:12 Changed 3 years ago by gk

Cc: mcs brade added

comment:13 Changed 3 years ago by mcs

r=mcs
Looks good to me.

comment:14 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Fixed with commit 5d2f77c0c56a62199fab2034ba14686867808b82 on master.

comment:15 Changed 3 years ago by cypherpunks

Keywords: tbb-usability-website tbb-security-slider removed
Note: See TracTickets for help on using tickets.