Opened 2 years ago

Closed 2 years ago

#21889 closed enhancement (fixed)

hs: Circuitmap changes for prop224

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224
Cc: asn Actual Points:
Parent ID: #21888 Points: 3
Reviewer: nickm Sponsor: SponsorR-must

Description

This is part of the groundwork for service implementation of prop224 (#20657).

First, we need the circuitmap API to use a circuit_t instead of or_circuit_t so we can use it on the service side which uses origin_circuit_t.

Second, add a service side API to track service circuits.

Finally, refactor this API so the naming has better semantic.

Child Tickets

Change History (8)

comment:1 Changed 2 years ago by dgoulet

Reviewer: nickm
Status: newneeds_review

This has been taken from asn's work and reviewed by dgoulet.

Branch: ticket21889_031_01
Gitlab review: https://gitlab.com/dgoulet/tor/merge_requests/19

comment:2 Changed 2 years ago by asn

Cc: asn added

comment:3 Changed 2 years ago by nickm

I left a quick suggestion; looks fine otherwise.

comment:4 Changed 2 years ago by nickm

Status: needs_reviewneeds_revision

comment:5 Changed 2 years ago by dgoulet

Status: needs_revisionneeds_review

I've addressed comments in fixup commits.

comment:6 Changed 2 years ago by nickm

I think one of the assertions you added in 133158095be5d56cb7c9d4b2e9e5d568f9b1f368 is reversed ; there should be a "!".

comment:7 Changed 2 years ago by dgoulet

Indeed and not only that but that assert() triggered a bug we had in the code (not used so safe).

See fixup commit 6650cb99.

We actually have to look for both type of rendezvous circuit when looking for a service side circuit.

Very good catch nickm!

comment:8 Changed 2 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

thanks for the fix; squashed and merged.

Note: See TracTickets for help on using tickets.