Opened 3 years ago

Closed 2 years ago

#21890 closed defect (fixed)

Don't skip unrecognized lines in certain cases

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone: metrics-lib 1.7.0
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When we started using Java 7's switch-on-String in 2b4d773, we broke unrecognized line parsing in extra-info descriptors. Namely, when we reached the end of a crypto block we didn't reset the list for collecting crypto lines. So far so good, but any following unrecognized lines would be collected as crypto lines and later discarded, rather than being added to the unrecognized-lines list and later reported.

This only affects relay descriptors, because sanitized bridge descriptors don't contain crypto blocks. And it only affects relay descriptors with crypto blocks, like "identity-ed25519", whereas relay extra-info descriptors published by older versions were not affected.

Branch follows in a second.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by karsten

Status: newneeds_review

Please review my task-21890 branch.

comment:2 Changed 2 years ago by iwakeh

Status: needs_reviewmerge_ready

Looks fine; new tests; all tests and checks pass.
Ready for merge.

comment:3 Changed 2 years ago by iwakeh

Milestone: metrics-lib 1.7.0

comment:4 Changed 2 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Thanks for reviewing! Merged and pushed to master. Closing.

Note: See TracTickets for help on using tickets.