Opened 13 months ago

Closed 13 months ago

Last modified 4 months ago

#21907 closed defect (fixed)

Tor Browser nightly (based on ESR52) is not running on CentOS 6

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, TorBrowserTeam201704R, tbb-7.0-must-alpha, tbb-no-uplift
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Starting Tor Browser nightly on CentOS 6.9 gives me the following error:

XPCOMGlueLoad error for file /home/boklm/tb/nightly/tor-browser/Browser/libxul.so:
/home/boklm/tb/nightly/tor-browser/Browser/libxul.so: undefined symbol: g_bytes_unref
Couldn't load XPCOM.

Version 7.0a2 is starting correctly on CentOS 6.9.

Child Tickets

Attachments (2)

Change History (13)

comment:2 Changed 13 months ago by gk

According to https://developer.mozilla.org/en-US/Firefox/Linux_compatibility_matrix Debian Wheezy ships with glib 2.32 and RHEL6 with 2.28 and g_bytes_unref first appeared in 2.32. So, yeah.

comment:3 Changed 13 months ago by gk

boklm: can you come up with a smart fix for us? Maybe just backing out hb_glib_blob_create() as the reporter in https://bugzilla.mozilla.org/show_bug.cgi?id=1324780 mentioned? Or just tweaking the fixup a bit so that it works for us?. I assume we don't want to switch to centos6 for building the Linux bundles.

comment:4 Changed 13 months ago by gk

Keywords: TorBrowserTeam201704 tbb-7.0-must-alpha added

comment:5 Changed 13 months ago by boklm

I attached a patch backing out hb_glib_blob_create() in all cases. I am now making a build with this patch to confirm that it fixes the problem.

comment:6 Changed 13 months ago by boklm

A build with this patch now fails with:

XPCOMGlueLoad error for file /home/boklm/tb/rbm-nightly/tor-browser_en-US/Browser/libxul.so:
/home/boklm/tb/rbm-nightly/tor-browser_en-US/Browser/libxul.so: undefined symbol: g_unichar_fully_decompose
Couldn't load XPCOM.

comment:7 Changed 13 months ago by boklm

Keywords: TorBrowserTeam201704R added; TorBrowserTeam201704 removed
Status: newneeds_review

I uploaded a new version (v3) of the patch: 0001-Bug-21907-fix-runtime-error-on-CentOS-6-v3.patch​

In this version of the patch we are backing out more code that is for glib > 2.28. I think the reason why we did not need to back out this code in ESR45 is that the file hb-glib.cc was not built at all in that version, but was added to the build with the patch for mozilla bug 1306543.

After doing a build with this patch, I am able to run the browser on Centos 6.

comment:8 in reply to:  7 ; Changed 13 months ago by gk

Replying to boklm:

I uploaded a new version (v3) of the patch: 0001-Bug-21907-fix-runtime-error-on-CentOS-6-v3.patch​

In this version of the patch we are backing out more code that is for glib > 2.28. I think the reason why we did not need to back out this code in ESR45 is that the file hb-glib.cc was not built at all in that version, but was added to the build with the patch for mozilla bug 1306543.

After doing a build with this patch, I am able to run the browser on Centos 6.

Add I assume it is running on other Linux distros with newer library versions fine as well, right?

comment:9 in reply to:  8 Changed 13 months ago by boklm

Replying to gk:

Add I assume it is running on other Linux distros with newer library versions fine as well, right?

I was able to run it on Debian Jessie and Fedora 24.

comment:10 Changed 13 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Commit 4c6219dc621d139cd39e8aaca578dd69b9c063d0 on tor-browser-52.0.2esr-7.0-2 has the fix.

comment:11 Changed 4 months ago by arthuredelstein

Keywords: tbb-no-uplift added
Note: See TracTickets for help on using tickets.