Opened 2 years ago

Closed 2 years ago

#21920 closed enhancement (fixed)

Revert locale selection dialog changes in Tor Launcher

Reported by: gk Owned by: brade
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Normal Keywords: tbb-7.0-must-alpha, TorBrowserTeam201704R
Cc: mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

So far, we only used the locale selection dialog in the hardened builds. That is not needed anymore and can get removed on master for the time being. This makes dealing with Tor Launcher in our different Tor Browser series a lot easier. We can pick those changes up again later or build on top of them if needed

Child Tickets

Change History (7)

comment:1 Changed 2 years ago by gk

Keywords: TorBrowserTeam201704R added; TorBrowserTeam201704 removed
Status: newneeds_review

bug_21920 (https://gitweb.torproject.org/user/gk/tor-launcher.git/log/?h=bug_21920, the last two commits) has all the changes reverted I think. mcs/brade could you doublecheck that I don't have missed anything and that the backouts are correct? I had some conflicts but think I got them properly resolved.

comment:2 Changed 2 years ago by mcs

Keywords: TorBrowserTeam201704 added; TorBrowserTeam201704R removed
Status: needs_reviewneeds_revision

The backout is somewhat messy. Are you sure we are not going to want this feature again someday? It would be much easier to just change shouldPromptForLocale() to always return false.

Looking at your changes, they look okay with the following small comments:

  • The check against mRestartWithQuit can be removed from tl-process.js (nothing sets that property).
  • Kathy and I would prefer to keep the following prefs near the top of defaults/preferences/prefs.js so as to avoid confusion (since they are not related to the control port prefs): extensions.torlauncher.start_tor and extensions.torlauncher.prompt_at_startup

comment:3 Changed 2 years ago by gk

I am fine with either approach. We definitely want #17400 to get fixed properly some day (sooner than later). It's not clear to me yet whether we want to use the code in Tor Launcher for that, though. Probably, but who knows. Anyway, I am preparing a patch doing the easier change you suggested as we can back out the code later if we really don't want it. The additional code we need to carry around is not that much of a burden I guess.

comment:4 Changed 2 years ago by gk

Keywords: TorBrowserTeam201704R added; TorBrowserTeam201704 removed
Status: needs_revisionneeds_information

comment:5 Changed 2 years ago by gk

Status: needs_informationneeds_review

comment:6 Changed 2 years ago by mcs

r=brade, r=mcs
Ship it!

comment:7 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

On its way with commit afb9893b7626ce819d7b2b571a847d44277971f6 on master, thanks.

Note: See TracTickets for help on using tickets.