Revert locale selection dialog changes in Tor Launcher

So far, we only used the locale selection dialog in the hardened builds. That is not needed anymore and can get removed on master for the time being. This makes dealing with Tor Launcher in our different Tor Browser series a lot easier. We can pick those changes up again later or build on top of them if needed

added TorBrowserTeam201704R component::applications/tor launcher owner::brade priority::medium resolution::fixed severity::normal status::closed tbb-7.0-must-alpha type::enhancement labels

bug_21920 (https://gitweb.torproject.org/user/gk/tor-launcher.git/log/?h=bug_21920, the last two commits) has all the changes reverted I think. mcs/brade could you doublecheck that I don't have missed anything and that the backouts are correct? I had some conflicts but think I got them properly resolved.

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201704 deleted, TorBrowserTeam201704R added

The backout is somewhat messy. Are you sure we are not going to want this feature again someday? It would be much easier to just change shouldPromptForLocale() to always return false.

Looking at your changes, they look okay with the following small comments:

• The check against mRestartWithQuit can be removed from tl-process.js (nothing sets that property).
• Kathy and I would prefer to keep the following prefs near the top of defaults/preferences/prefs.js so as to avoid confusion (since they are not related to the control port prefs): extensions.torlauncher.start_tor and extensions.torlauncher.prompt_at_startup

Trac:
Keywords: TorBrowserTeam201704R deleted, TorBrowserTeam201704 added
Status: needs_review to needs_revision

I am fine with either approach. We definitely want #17400 (moved) to get fixed properly some day (sooner than later). It's not clear to me yet whether we want to use the code in Tor Launcher for that, though. Probably, but who knows. Anyway, I am preparing a patch doing the easier change you suggested as we can back out the code later if we really don't want it. The additional code we need to carry around is not that much of a burden I guess.

bug_21920_v4 (https://gitweb.torproject.org/user/gk/tor-launcher.git/commit/?h=bug_21920_v4&id=afb9893b7626ce819d7b2b571a847d44277971f6) is up for review.

Trac:
Status: needs_revision to needs_information
Keywords: TorBrowserTeam201704 deleted, TorBrowserTeam201704R added

Trac:
Status: needs_information to needs_review

r=brade, r=mcs Ship it!

On its way with commit afb9893b7626ce819d7b2b571a847d44277971f6 on master, thanks.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #25260 (moved)

moved to tpo/applications/tor-launcher#21920 (closed)