Opened 3 years ago

Closed 3 years ago

#21930 closed defect (fixed)

NSS libraries are missing from mar-tools archive

Reported by: mcs Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-gitian, ff52-esr, tbb-7.0-must-alpha, TorBrowserTeam201704R
Cc: brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor4

Description

While testing mar file generation on Linux, Kathy and I discovered that the signmar program from mar-tools-linux64.zip will not start. The error message displayed is:

ERROR: Could not initialize NSS

Trying to run certutil produces a more informative error message:

certutil: function failed: PR_LOAD_LIBRARY_ERROR: Failure to load dynamic library
libsoftokn3.so: cannot open shared object file: No such file or directory

I think we probably need libfreebl3.so as well.

Why were those two libraries removed from NSS_LIBS in gitian-firefox.yml as part of #21239? Are they not built at all, or maybe they are in a different location in ESR52?

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by gk

Status: newneeds_information

The freebl one is different now. It's called libfreeblpriv3.so I think I tested whether the mar tool needed that one and the libsoftokn3.so lib and it worked for me without both. So, does adding libfreeblpriv3.so and libsoftokn3.so fix the problem for you? (Do we need both?)

comment:2 Changed 3 years ago by gk

Hm. So, maybe I tested not hard enough given that the MAR creation *is* working in our nightly builds? Like mar does not need those libs but signmar actually does? If so, sorry for the extra work.

comment:3 in reply to:  2 ; Changed 3 years ago by mcs

Replying to gk:

Hm. So, maybe I tested not hard enough given that the MAR creation *is* working in our nightly builds? Like mar does not need those libs but signmar actually does? If so, sorry for the extra work.

Yes, mar does not use any NSS stuff but signmar does.
I don't know for sure because I don't have libfreeblpriv3.so and libsoftokn3.so. I just started a build that will package them into the mar-tools archive, so I will check in the morning. Maybe you have a quicker way of checking though.

comment:4 in reply to:  3 Changed 3 years ago by mcs

Keywords: TorBrowserTeam201704R added; TorBrowserTeam201704 removed
Status: needs_informationneeds_review

Replying to mcs:

I don't know for sure because I don't have libfreeblpriv3.so and libsoftokn3.so. I just started a build that will package them into the mar-tools archive, so I will check in the morning. Maybe you have a quicker way of checking though.

My build progressed far enough for me to determine that signmar needs both libfreeblpriv3.so and libsoftokn3.so. Here is a patch:

https://gitweb.torproject.org/user/brade/tor-browser-bundle.git/commit/?h=bug21930-01

I restarted my build with this patch in place and will check the results tomorrow morning my time.

comment:5 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. This is commit c2bae45c6a41923712bf176df6fb9bd1f773d887 on master. Please reopen if we need to do more to fix this issue.

Note: See TracTickets for help on using tickets.