#21931 closed defect (fixed)

backport OSX SetupMacCommandLine updater fixes

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, TorBrowserTeam201704R
Cc: brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While testing the updater with an ad hoc (non-gitian) build, Kathy and I ran into https://bugzilla.mozilla.org/show_bug.cgi?id=1335916. With gitian-based builds (which are compiled and linked with an older OSX SDK than our ad hoc ones are), the code does not crash but it does emit a warning:

WARNING: nextEventMatchingMask should only be called from the Main Thread! This will throw an exception in the future.

We should backport the Mozilla fix for 1335916, as well as a follow up fix from https://bugzilla.mozilla.org/show_bug.cgi?id=1342887.

I will create a branch that contains the cherry picked patches.

Child Tickets

Change History (2)

comment:1 Changed 23 months ago by mcs

Keywords: ff52-esr TorBrowserTeam201704R added
Status: newneeds_review

The most recent two commits from this branch are ready for review:
https://gitweb.torproject.org/user/brade/tor-browser.git/log/?h=bug21931-01

comment:2 Changed 23 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Applied on tor-browser-52.0.2esr-7.0-2 with commit 899435e1997583bd01ab31e363fe3153486dd134 and 4cec6538e51ac73c6a46ec582ee0b2794c7d81d9.

Note: See TracTickets for help on using tickets.