Opened 3 years ago

Closed 3 years ago

#21963 closed defect (fixed)

consdiff code accepts invalid patch

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by Sebastian)

We shouldn't accept a patch that includes commands of the form
'1,2a' because ranges for an add command don't make sense. I don't believe this is a breaking change because we never *generated* such diffs.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by Sebastian

Description: modified (diff)

comment:2 Changed 3 years ago by Sebastian

Status: newneeds_review

consdiff_add in my repo

comment:3 Changed 3 years ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.3.1.x-final

It looks like something might be disabled: I think that consdiff_add and consdiff_newline are actually the same patch?

comment:4 Changed 3 years ago by Sebastian

You're right, sorry. The code in both branches is supposed to be for this ticket. I'll push a new consdiff_newline branch for the other ticket when I find the code again.

comment:5 Changed 3 years ago by nickm

Merged consdiff_add. Thanks!

comment:6 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.