Opened 2 years ago

Closed 2 years ago

#21966 closed defect (fixed)

consdiff generation incorrect

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

trying to get a diff between "B\n" and "A\nB\n" produces an empty diff, rather than "0a\nA\n.\n"

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by Sebastian

Status: newneeds_review

fix in consdiff_newline in my repo

comment:2 Changed 2 years ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.3.1.x-final

comment:3 Changed 2 years ago by nickm

It looks like something might be disabled: I think that consdiff_add and consdiff_newline are actually the same patch?

comment:4 Changed 2 years ago by Sebastian

Pushed the correct branch to consdiff_newline now, sorry :(

comment:5 Changed 2 years ago by nickm

Merged consdiff_newline. Thanks!

comment:6 Changed 2 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.