Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#21968 closed defect (fixed)

Use proper headers for the family member groups

Reported by: cypherpunks Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


The family member groups on the relay page do not use proper headers (no bold font). They also do not have tooltips explaining what the difference between the groups are.

Child Tickets

Attachments (2)

0001-Add-proper-headers-for-each-family-member-group.patch (2.6 KB) - added by cypherpunks 8 months ago.
0002-Use-the-same-color-for-both-family-member-groups.patch (1.6 KB) - added by cypherpunks 8 months ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 months ago by cypherpunks

Status: newneeds_review

Using proper headers makes using different colors unnecessary so I've made the colors consistent in patch 0002.

comment:2 Changed 8 months ago by irl

Resolution: fixed
Status: needs_reviewclosed

I've merged the first patch. I'm not convinced by the removal of the colours in the second patch. It may just be that I'm used to seeing them. If we did Atlas again, I wouldn't include them, but I see no reason to remove them now that they are already there as that may confuse people unnecessarily.

Thanks for your work. Please reopen the ticket if you feel strongly on the colour issue.

comment:3 Changed 8 months ago by cypherpunks

For some context, the color was added in commit d7bbd232b69cce930cb97abca79769207cfa976b about ~1.5 years ago. I agree that people are probably conditioned by it now so I'll leave it be.

Note: See TracTickets for help on using tickets.