prop224: Load and configure service

This is a much bigger patch implementing a key feature of hidden service. Loading and configuring a service from the torrc file.

A new object is added which is hs_service_t representing a v3 service. The hs_config.[ch] files are introduced which loads the options and create an hs_service_t object out of it.

Like the legacy code, it goes in two steps. First, load the options and validate. Then, load/generate the keys if not in validate mode.

Some refactoring of the legacy code was needed in order to have a central entry point for the configuration of the HS options for both v2 and v3.

changed milestone to %Tor: 0.3.2.x-final

added component::core tor/tor milestone::Tor: 0.3.2.x-final owner::dgoulet parent::20657 points::6 priority::medium prop224 resolution::implemented review-group-19 review-group-20 reviewer::asn reviewer::nickm severity::normal sponsor::R-must status::closed tor-hs type::enhancement labels

This depends on #21978 (moved) branch so I'll wait for it to be merged upstream before submitting a branch for review.

Trac:
Status: new to accepted

This is actually pretty big and introduces a lot of prop224 service code so lets aim for early 032 instead.

Trac:
Milestone: Tor: 0.3.1.x-final to Tor: 0.3.2.x-final

Ready for review. This is pretty big but should be kind of easy to follow (I hope!). I've extracted 11 commits from #20657 (moved). Unit tests coverage is 100% I believe.

Branch: ticket21979_032_01 Gitlab review: https://gitlab.com/dgoulet/tor/merge_requests/30

Trac:
Status: accepted to needs_review
Reviewer: N/A to asn

Trac:
Keywords: N/A deleted, review-group-19 added

asn has started the damage on the branch ;). Important fix went in this new branch.

Branch: ticket21979_032_02 Oniongit review: https://oniongit.eu/dgoulet/tor/merge_requests/1

Hey David, I submitted the first round of review on gitlab. I'm still not done with the branch but that's a start. The branch seems to work pretty well here.

BTW, it would be nice if I had some more service-side code to review/test because just loading HSes does not give me much testing surface. If I had some code that also uses the generated HS that would be more useful for review/testing. Do you think that's a good time to prepare for me the second batch of service-side code for review? Or should I keep reviewing this codebase more?

Trac:
Status: needs_review to needs_revision

Oniongit comment addressed. Back in needs_review. Fixup commit in the original branch (ticket21979_032_02).

Trac:
Status: needs_revision to needs_review

Trac:
Keywords: N/A deleted, review-group-20 added

Thanks asn for this review! We are now in "nickm's eagle eye" mode.

This is pretty big so be advised. It's based on git master 948158df33c4cbfa03f2aa4990097b4e9de664a1.

Branch: ticket21979_032_03 Oniongit: https://oniongit.eu/dgoulet/tor/merge_requests/4

Trac:
Status: needs_review to merge_ready

Reviewed! Please let me know if you've any questions.

Trac:
Status: merge_ready to needs_revision

I addressed everything I think!

Branch is still: ticket21979_032_03

Trac:
Status: needs_revision to needs_review
Reviewer: asn to asn, nickm

Okay! I answered questions on that yesterday, but didn't go over the new code yet. I'll have a look now.

See branch ticket21979_032_04 for the squashed fixup.

On extra commit on it to fix clang warnings: 965e3a66

Trac:
Status: needs_review to merge_ready

lgtm. Merging!

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

changed time estimate to 48h