Add the option for debug builds to rbm

The hardened series contained features like ASan that helped us spot problems in our code earlier. We want to have similar nightly builds when switching to rbm. The tor-browser code still contains .mozconfig-asan which should be usable and I guess there are other things that can get salvaged from the descriptors in the hardened-builds branch as well.

added TorBrowserTeam201712R component::applications/tor browser owner::tbb-team parent::17379 priority::very high resolution::fixed severity::normal sponsor::4 status::closed tbb-rbm type::enhancement labels

Trac:
Keywords: N/A deleted, tbb-rbm added

Trac:
Keywords: N/A deleted, TorBrowserTeam201711 added
Sponsor: N/A to Sponsor4

Changing prio to reflect sponsor deadline

Trac:
Priority: High to Very High

The branch bug_21998 has a patch for review: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_21998&id=15d50182b0d16477a82cc7a1edf1c50b72e349d8

This change requires the fix from #24361 (moved).

The build fails because of #21925 (moved). In branch bug_21925 I added an other commit adding a workaround for #21925 (moved): https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_21925&id=01fe8c5c6a360c24433c36c37420aa8754e4dea5

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201711 deleted, TorBrowserTeam201711R added

Thanks. I have two things that need to get fixed:

The resulting bundle does not start for me due to wrong file permissions:

-rw------- 1 thomas thomas 12930 Jan  1  2000 Browser/start-tor-browser

--enable-expensive-hardening is deprecated. We should use --enable-fragile-hardening instead for tor. See: #21290 (moved) for more details and commit 5335a8e6f8317ea3645227d139369f8931cdb299 for the actual change.

Trac:
Keywords: TorBrowserTeam201711R deleted, TorBrowserTeam201711 added
Status: needs_review to needs_revision

I pushed a new version of the patch fixing those 2 issues in branch bug_21998_v3: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_21998_v3&id=61ee91b5aa8975743b0daaf3c9ac80c5b00ccc10

I rebased the workaround for #21925 (moved) in branch bug_21925_v3: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_21925_v3&id=a634ea5f9b56273a7173f1c17ddc6e0bd055903e

Trac:
Status: needs_revision to needs_review

Thanks. One final thing. I am a bit wary to start collecting Firefox patches in tor-browser-build. While I think there could be an argument made for the #23231 (moved) workaround (who really is using plain tor-browser.git to cross-compile stuff for Windows??) I think it does not hold for the ASan case. We are shipping a .mozconfig-asan file and, in fact, if one uses Linux and wants to do dev work there is no need to use an rbm build for that. Thus, let's keep the workaround for #21925 (moved) in tor-browser.git. There should not be any breakage for the non-ASan series regardless the platform we compile for. And it would make the tor-browser-build patch simpler.

Trac:
Keywords: TorBrowserTeam201711 deleted, TorBrowserTeam201712 added
Status: needs_review to needs_revision

commit 61ee91b5aa8975743b0daaf3c9ac80c5b00ccc10 looks good to me. I'll pick it up once #21925 (moved) is resolved.

Trac:
Keywords: TorBrowserTeam201712 deleted, TorBrowserTeam201712R added
Status: needs_revision to needs_review

I rebased commit 61ee91b5aa8975743b0daaf3c9ac80c5b00ccc10 on master in branch bug_21998_v4: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_21998_v4&id=055e751493bedd4914605f418aee590ba79f96d7

Thanks. Applied to master as commit 055e751493bedd4914605f418aee590ba79f96d7 and the merge conflict resolved in commit d0f2bcf4697fe06cb034e412bd6d262ac12d3a3e.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #24154 (moved)

mentioned in issue #24361 (moved)

mentioned in issue tpo/applications/rbm#24361 (closed)

moved to tpo/applications/tor-browser#21998 (closed)