Opened 8 months ago

Closed 12 days ago

#21998 closed enhancement (fixed)

Add the option for debug builds to rbm

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201712R
Cc: boklm Actual Points:
Parent ID: #17379 Points:
Reviewer: Sponsor: Sponsor4

Description

The hardened series contained features like ASan that helped us spot problems in our code earlier. We want to have similar nightly builds when switching to rbm. The tor-browser code still contains .mozconfig-asan which should be usable and I guess there are other things that can get salvaged from the descriptors in the hardened-builds branch as well.

Child Tickets

TicketTypeStatusOwnerSummary
#21925defectclosedtbb-teamTor Browser based on ESR52 can't get built with ASan and FORTIFY_SOURCE
#24361defectclosedboklmrbm gives an error if a build script contains a wide character

Change History (10)

comment:1 Changed 5 months ago by boklm

Keywords: tbb-rbm added

comment:2 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201711 added
Sponsor: Sponsor4

comment:3 Changed 6 weeks ago by gk

Priority: HighVery High

Changing prio to reflect sponsor deadline

comment:4 Changed 4 weeks ago by boklm

Keywords: TorBrowserTeam201711R added; TorBrowserTeam201711 removed
Status: newneeds_review

comment:5 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201711 added; TorBrowserTeam201711R removed
Status: needs_reviewneeds_revision

Thanks. I have two things that need to get fixed:

1)
The resulting bundle does not start for me due to wrong file permissions:

-rw------- 1 thomas thomas 12930 Jan  1  2000 Browser/start-tor-browser

2)
--enable-expensive-hardening is deprecated. We should use --enable-fragile-hardening instead for tor. See: #21290 for more details and commit 5335a8e6f8317ea3645227d139369f8931cdb299 for the actual change.

comment:6 Changed 3 weeks ago by boklm

Status: needs_revisionneeds_review

comment:7 Changed 2 weeks ago by gk

Keywords: TorBrowserTeam201712 added; TorBrowserTeam201711 removed
Status: needs_reviewneeds_revision

Thanks. One final thing. I am a bit wary to start collecting Firefox patches in tor-browser-build. While I think there could be an argument made for the #23231 workaround (who really is using plain tor-browser.git to cross-compile stuff for Windows??) I think it does not hold for the ASan case. We are shipping a .mozconfig-asan file and, in fact, if one uses Linux and wants to do dev work there is no need to use an rbm build for that. Thus, let's keep the workaround for #21925 in tor-browser.git. There should not be any breakage for the non-ASan series regardless the platform we compile for. And it would make the tor-browser-build patch simpler.

comment:8 Changed 12 days ago by gk

Keywords: TorBrowserTeam201712R added; TorBrowserTeam201712 removed
Status: needs_revisionneeds_review

commit 61ee91b5aa8975743b0daaf3c9ac80c5b00ccc10 looks good to me. I'll pick it up once #21925 is resolved.

Last edited 12 days ago by gk (previous) (diff)

comment:9 Changed 12 days ago by boklm

I rebased commit 61ee91b5aa8975743b0daaf3c9ac80c5b00ccc10 on master in branch bug_21998_v4:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_21998_v4&id=055e751493bedd4914605f418aee590ba79f96d7

comment:10 Changed 12 days ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Applied to master as commit 055e751493bedd4914605f418aee590ba79f96d7 and the merge conflict resolved in commit d0f2bcf4697fe06cb034e412bd6d262ac12d3a3e.

Note: See TracTickets for help on using tickets.