Opened 2 years ago

Closed 3 months ago

Last modified 3 months ago

#22022 closed enhancement (implemented)

Move to cryptography for ed25519 validation

Reported by: atagar Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Minor Keywords: descriptor unactionable
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Presently Stem uses PyNaCl for ed25519 certificate validation. We use cryptography elsewhere and it would be nice to use it for this validation as well (dropping the extra dependency) once support is available. This is pending...

https://github.com/pyca/cryptography/issues/3509

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by atagar

OpenSSL just added ed25519 support. Cryptography will be adding it in their upcoming 1.1.1.1 release. Yay! \o/

Last edited 2 years ago by atagar (previous) (diff)

comment:2 Changed 12 months ago by atagar

Keywords: unactionable added

Oops, seems I spoke too soon. This looks to be the upstream tracking ticket.

https://github.com/pyca/cryptography/pull/4114

comment:3 Changed 3 months ago by illia-v

Hello @atagar,

Cryptography added ed25519 support.

I tried to modify the library to use cryptography instead of PyNaCl: https://github.com/illia-v/stem/commit/f58577435c91b56f9381f07cb6486a17f9b7ad9a.
Can you please review the commit?

comment:4 Changed 3 months ago by atagar

Resolution: implemented
Status: newclosed

Yikes! This was a perfect patch. Thank you Illia, this was much appreciated. :)

comment:5 Changed 3 months ago by illia-v

Thanks, Damian!

Note: See TracTickets for help on using tickets.