Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2203 closed defect (fixed)

Tor clients and authorities do not check bad_exit flag w/ consensus weights

Reported by: mikeperry Owned by: mikeperry
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It looks like neither clients nor the directory authorities are properly handling the BadExit flag when computing and using the Wxx consensus weights.

On the client side, this causes BadExits to be used less than if they were never exits in the first place.

On the consensus side, this causes us to think there is more Exit bandwidth available in the network than there actually is, which can cause us to overload actual exits by assigning them higher weights to be used in the guard and middle positions.

Child Tickets

Change History (9)

comment:1 Changed 9 years ago by mikeperry

Owner: set to mikeperry
Status: newassigned

comment:2 Changed 9 years ago by nickm

Milestone: Tor: 0.2.2.x-final

Assigning the client side of this at least to the 0.2.2.x milestone. We could let it slip to 0.2.3.x if we had to, but let's not unless it's really hard.

comment:3 Changed 9 years ago by mikeperry

Status: assignedneeds_review

Ok, both the client side and the dirauth side are fixed in mikeperry/bug2203. Complete with changelog entry.

comment:4 Changed 9 years ago by nickm

I had to rebase this onto 0.2.2, and tweak it a bit as I went. I also documented the new consensus method. Could you please have a look at my revised code and documentation in branch "bug2203_rebased" in my public repository?

comment:5 Changed 9 years ago by Sebastian

I'll point this out before arma does: in your dir-spec patch, "conesensus".

Seems to work fine, I tested it briefly in a private network.

comment:6 Changed 9 years ago by nickm

typo fixed in bug2203_rebased

comment:7 Changed 9 years ago by mikeperry

I looked at the new branch, and it seems fine to me.

comment:8 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

okay, merging it. Thanks, all!

comment:9 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.