When I use the search box in the upper right it defaults to using youtube (on macOS)

when I use the search box in the upper right it defaults to using youtube instead of duckduckgo. macOS 10.12.4 (16E195) TBB 7.0a3

Trac:
Username: Dbryrtfbcbhgf

added TorBrowserTeam201705R component::applications/tor browser ff52-esr owner::mcs priority::medium reporter::Dbryrtfbcbhgf resolution::fixed severity::normal status::closed tbb-7.0-must-alpha type::defect labels

I observe similar behavior on macOS 10.10.5 but haven't investigated further.

Replying to Dbryrtfbcbhgf:

when I use the search box in the upper right it defaults to using youtube instead of duckduckgo. macOS 10.12.4 (16E195) TBB 7.0a3

Hm. This seems to work on my Linux box. Which locale are you using?

Trac:
Status: new to needs_information

macOS 10.12.4 (16E195)

Trac:
Username: Dbryrtfbcbhgf

Deleted ~/Library/Application Support/TorBrowser-Data, deleted TorBrowser.app. Reinstalled 7.0a3 from TorBrowser-7.0a3-osx64_en-US.dmg. Search still defaults to YouTube for me.

I just rechecked a freshly installed 6.5.2 from TorBrowser-6.5.2-osx64_en-US.dmg (after deleting TorBrowser-Data) and it defaults to DuckDuckGo as expected.

Thanks for testing. This does not happen on Windows either which makes me wondering whether that is a macOS-only issue as #21879 (moved) with the same underlying root cause.

Trac:
Status: needs_information to assigned
Version: Tor: 0.3.0.5-rc to N/A
Keywords: N/A deleted, tbb-7.0-must, ff52-esr added
Cc: N/A to mcs, brade

Moving tickets onto our alpha radar.

Trac:
Keywords: tbb-7.0-must deleted, tbb-7.0-must-alpha added

Trac:
Summary: when I use the search box in the upper right it defaults to using youtube. to When I use the search box in the upper right it defaults to using youtube (on macOS)

Trac:
Cc: mcs, brade to mcs, brade, arthuredelstein, gk
Owner: tbb-team to mcs
Keywords: N/A deleted, TorBrowserTeam201705 added

The difference on OSX is due to https://bugzilla.mozilla.org/show_bug.cgi?id=1126722. But the real problem is that we are not setting the default search engine correctly: browser.search.defaultenginename needs to contain an URL. This is because the getter for originalDefaultEngine, which is defined in browser/app/profile/000-tor-browser.js, uses nsIPrefBranch.getComplexValue() to retrieve the pref value. The solution is to use a data: URL for the value (Mozilla definesbrowser.search.defaultenginename.US that way). Here is a patch: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug22044-01&id=a6a714a4541b3821267558c8c0a5ef725a91331a

Trac:
Status: assigned to needs_review
Keywords: TorBrowserTeam201705 deleted, TorBrowserTeam201705R added

Looks good to me, thanks. This is commit e6b99c78fdc1800988537c73ef13e75b56c28b3e on tor-browser-52.1.0esr-7.0-2.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#22044 (closed)