Opened 2 years ago

Closed 2 years ago

#22046 closed defect (fixed)

Remove cruft

Reported by: cypherpunks Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The Atlas repository contains several files which are duplicate, from the Tor Status era, or unused.

Child Tickets

Attachments (1)

0001-Remove-cruft.patch (1.2 MB) - added by cypherpunks 2 years ago.

Download all attachments as: .zip

Change History (5)

Changed 2 years ago by cypherpunks

Attachment: 0001-Remove-cruft.patch added

comment:1 Changed 2 years ago by cypherpunks

Status: newneeds_review

comment:2 Changed 2 years ago by irl

Status: needs_reviewneeds_information

I don't seem to be able to get this one to apply.

I can see what's happening with the deletions, what's up with the renames? I can apply the diff manually if you can give some context on the renames.

Thanks for your work on this, it's been bugging me for a while. (:

comment:3 in reply to:  2 Changed 2 years ago by cypherpunks

Replying to irl:

I don't seem to be able to get this one to apply.

I've tested the patch and indeed it doesn't apply with git am. It seems to be an issue with the line endings. Using git am --keep-cr makes the patch apply properly.

I can see what's happening with the deletions, what's up with the renames? I can apply the diff manually if you can give some context on the renames.

The renames are meant to keep the files that are part of Bootstrap intact. IMO the directory structure could be improved further by keeping all Bootstrap files in one directory instead of splitting them across multiple but that's out of the scope of this ticket.

Thanks for your work on this, it's been bugging me for a while. (:

Me too, grepping for things would regularly turn up unrelated and duplicated files which got annoying.

comment:4 Changed 2 years ago by irl

Resolution: fixed
Status: needs_informationclosed

Ok, it worked with --keep-cr. (:

Thanks. Merged.

Note: See TracTickets for help on using tickets.