Opened 2 years ago

Closed 2 years ago

#22065 closed enhancement (implemented)

prop278: Parse the Accept-Encoding header and pass it to "get" handlers

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: prop278 TorCoreTeam201704
Cc: ahf Actual Points: .1
Parent ID: #21667 Points: .1
Reviewer: Sponsor: Sponsor4

Description

I need this for my prop140 work.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by nickm

Cc: ahf added

The branch parse_accept_encoding in my public repository is now ready for review.

comment:2 Changed 2 years ago by nickm

Status: newneeds_review

comment:3 Changed 2 years ago by nickm

Component: - Select a componentCore Tor/Tor

comment:4 Changed 2 years ago by ahf

Status: needs_reviewmerge_ready

Looks good. I have one comment:

In 65ff0f8267b99a55a099eec2a71cb45557ae84eb the HAVE_LZMA and HAVE_ZSTD macros are used to build the SUPPORTED_COMPRESSION_MASK bitmask. Shouldn't we consider lifting that into the compress module instead with a public API there?

comment:5 Changed 2 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

Good point; I've moved the code for that, and merged the branch.

Note: See TracTickets for help on using tickets.