Opened 9 years ago

Closed 4 years ago

#2207 closed defect (wontfix)

special URL access may cause segfault (NULL-deref)

Reported by: meyering Owned by: chrisd
Priority: Medium Milestone:
Component: Polipo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

wget 'http://localhost:8123/polipo/index?'
can make polipo to dereference NULL.
That happens if this malloc fails:

request = malloc(sizeof(SpecialRequestRec));
if(request == NULL) {

...

} else {

...

}
...
request->object = object

I've attached a proposed patch:

Child Tickets

Attachments (1)

polipo-special-obj-NULL-deref.patch (1.2 KB) - added by meyering 9 years ago.
proposed patch

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by meyering

proposed patch

comment:1 Changed 9 years ago by rransom

Owner: set to chrisd
Status: newassigned

Looks reasonable to me. I don't think the exit here is any worse than some of the other places that call polipoExit.

comment:2 Changed 8 years ago by phobos

Resolution: wontfix

Polipo bugs should be opened at http://sourceforge.net/projects/polipo/

comment:3 Changed 4 years ago by arma

Severity: Normal
Status: assignedclosed
Note: See TracTickets for help on using tickets.