Opened 2 years ago

Closed 2 years ago

#22071 closed enhancement (fixed)

Disable redundant Kinto based blocklist update mechanism

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, tbb-7.0-must, TorBrowserTeam201705R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Mozilla is in the transition to move to a new blocklist update system based on Kinto which is more fine-grained as the old one that used a big XML document, see: https://wiki.mozilla.org/Firefox/Kinto

It seems both systems are running in parallel right now but only the old one is used (see: notify() in nsBlocklistService.js) (I guess we are still in Phase 1 as outlined on the above wiki page). We should disable the one based on Kinto as there is no need to do additional requests and be affected by possible Kinto-related code issues.

Flipping services.blocklist.update_enabled to false should be enough I think:

    // If kinto update is enabled, do the kinto update
    if (gPref.getBoolPref(PREF_BLOCKLIST_UPDATE_ENABLED)) {
      const updater =
        Components.utils.import("resource://services-common/blocklist-updater.js",
                                {});
      updater.checkVersions().catch(() => {
        // Before we enable this in release, we want to collect telemetry on
        // failed kinto updates - see bug 1254099
      });
    }

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by cypherpunks

Keywords: ff52-esr added; f52-esr removed

comment:2 Changed 2 years ago by gk

Keywords: TorBrowserTeam201705R added

comment:3 Changed 2 years ago by gk

Status: newneeds_review

comment:4 Changed 2 years ago by mcs

r=brade, r=mcs
Looks good to us.

comment:5 Changed 2 years ago by brade

Doh! mcs forgot to mention above that there is a typo in the 2nd line of the comment.
Perhaps change it to:
// one which is still used, see bug ...

comment:6 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, fixed the typo and added the fix as commit 38e1a1966adbbcb5a15edbf300f33f5de8d7aae6 to tor-browser-52.1.0esr-7.0-2.

Note: See TracTickets for help on using tickets.