Opened 4 months ago

Closed 6 weeks ago

#22073 closed enhancement (fixed)

Disable GetAddons pane on about:addons

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201707R
Cc: justJanne Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We don't know which extensions Mozilla is showing to users and we are generally of the opinion that Tor Browser should not used with additional extensions. We can make it harder for users to shoot themselves in the foot by just hiding the GetAddons pane with extensions.getAddons.showPane set to false.

Child Tickets

Change History (4)

comment:1 Changed 6 weeks ago by gk

Cc: justJanne added
Keywords: TorBrowserTeam201707 added

Resolved #22900 as duplicate.

comment:2 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201707R added; TorBrowserTeam201707 removed
Status: newneeds_review

See bug_22073_v2 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_22073_v2&id=b3989f16138112084c008f89d54ecbe9cd4804d7) which is up for review.

Not sure if we want to deal with users that have the GetAddons pane already selected. They will now see a spinning icon on about:addons until they select any of the other remaining options on the page.

comment:3 Changed 6 weeks ago by mcs

r=brade, r=mcs
This change is fine. The spinning icon problem is a little annoying but something we can probably live with as long as it does not happen when about:addons is opened for the very first time. On the browser console I see:

13:13:31.058 NS_ERROR_FAILURE: Root node doesn't exist for 'discover' view 1 extensions.js:852
	gViewController.loadViewInternal chrome://mozapps/content/extensions/extensions.js:852:13
	gViewController.loadInitialView chrome://mozapps/content/extensions/extensions.js:822:5
	initialize chrome://mozapps/content/extensions/extensions.js:238:3

comment:4 Changed 6 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

That should not happen as the default in that case at least is set to addons://list/extension (see: https://dxr.mozilla.org/mozilla-esr52/source/toolkit/mozapps/extensions/content/extensions.js#207). This is commit b3989f16138112084c008f89d54ecbe9cd4804d7 on tor-browser-52.2.0esr-7.5-1. I guess we could think about backporting it to the stable branch as well.

Note: See TracTickets for help on using tickets.