Disable GetAddons pane on about:addons

We don't know which extensions Mozilla is showing to users and we are generally of the opinion that Tor Browser should not used with additional extensions. We can make it harder for users to shoot themselves in the foot by just hiding the GetAddons pane with extensions.getAddons.showPane set to false.

added TorBrowserTeam201707R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed type::enhancement labels

Resolved #22900 (moved) as duplicate.

Trac:
Cc: N/A to justJanne
Keywords: N/A deleted, TorBrowserTeam201707 added

See bug_22073_v2 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_22073_v2&id=b3989f16138112084c008f89d54ecbe9cd4804d7) which is up for review.

Not sure if we want to deal with users that have the GetAddons pane already selected. They will now see a spinning icon on about:addons until they select any of the other remaining options on the page.

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201707 deleted, TorBrowserTeam201707R added

r=brade, r=mcs This change is fine. The spinning icon problem is a little annoying but something we can probably live with as long as it does not happen when about:addons is opened for the very first time. On the browser console I see:

13:13:31.058 NS_ERROR_FAILURE: Root node doesn't exist for 'discover' view 1 extensions.js:852
	gViewController.loadViewInternal chrome://mozapps/content/extensions/extensions.js:852:13
	gViewController.loadInitialView chrome://mozapps/content/extensions/extensions.js:822:5
	initialize chrome://mozapps/content/extensions/extensions.js:238:3

That should not happen as the default in that case at least is set to addons://list/extension (see: https://dxr.mozilla.org/mozilla-esr52/source/toolkit/mozapps/extensions/content/extensions.js#207). This is commit b3989f16138112084c008f89d54ecbe9cd4804d7 on tor-browser-52.2.0esr-7.5-1. I guess we could think about backporting it to the stable branch as well.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #22900 (moved)

mentioned in issue #22966 (moved)

moved to tpo/applications/tor-browser#22073 (closed)