Opened 3 years ago

Closed 3 years ago

#22085 closed defect (fixed)

Refactor and simplify compression tests

Reported by: ahf Owned by: ahf
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: prop278, TorCoreTeam201704
Cc: Actual Points: 0.4
Parent ID: Points: 1
Reviewer: Sponsor: Sponsor4


The current compression tests contains a lot of copy and pasted source code. We should unify that to ensure that all the compression backends are tested at different compression levels.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by ahf

Actual Points: 0.4
Status: newneeds_review

comment:2 Changed 3 years ago by nickm

Owner: set to nickm
Status: needs_reviewassigned

Merged. I'm going to try a couple more things here, so keeping this open for now.

comment:3 Changed 3 years ago by nickm

Status: assignedneeds_review

My branch 22085_more has my changes here, along with what is (I think!) a genuine bugfix.

comment:4 Changed 3 years ago by ahf

Status: needs_reviewmerge_ready

Nice! Looks good to me. I'll remember to use the arguments to the test functions next time - way more clean approach now.

comment:5 Changed 3 years ago by nickm

Owner: changed from nickm to ahf
Status: merge_readyassigned


comment:6 Changed 3 years ago by nickm

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.