Opened 3 years ago

Closed 3 years ago

#22086 closed enhancement (implemented)

Make NO_METHOD a real legit compression method

Reported by: nickm Owned by: nickm
Priority: Low Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: cleanup null-object-pattern
Cc: Actual Points: 0.1
Parent ID: Points: 0
Reviewer: Sponsor: Sponsor4

Description

There are a few places in the code that do something like

  if (compressing) {
     tor_compress(...)
  } else {
     memcpy(...)
  }

Wouldn't it be great if they could just call tor_compress unconditionally?

They can, if NO_METHOD is treated as a real compression method!

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by nickm

See branch compress_none in my public repo. It's not tested -- I'll integrate it into #22085 if you like it.

comment:2 Changed 3 years ago by ahf

Status: newmerge_ready

Looks good! Would be nice to have it tested and included in #22085 firstly though :-)

comment:3 Changed 3 years ago by nickm

Status: merge_readyneeds_review

Rebased and added tests as compress_none_v2. Predictably, there were bugs, so I'm putting this back in needs_review. :)

comment:4 Changed 3 years ago by nickm

Actual Points: 00.1

comment:5 Changed 3 years ago by ahf

Status: needs_reviewmerge_ready

Looks good with the tests!

comment:6 Changed 3 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

Squashed and merged!

Note: See TracTickets for help on using tickets.