Adjust #19837 for ff52-esr (update our content policy whitelist)

No controls are visible and

[...] TypeError: this.scrubber.valueChanged is not a function videocontrols.xml:962:29

added TorBrowserTeam201706R component::applications/tor browser ff52-esr owner::mcs priority::medium resolution::fixed severity::normal status::closed tbb-regression type::defect labels

How can I reproduce this: Which operating system are you using and which website are you trying to load?

Trac:
Status: new to needs_information

STR: https://ia600201.us.archive.org/1/items/OrsonWellesMrBruns/381030.ogg If you don't see OS, test it on Windoze ;)

Trac:
Status: needs_information to new

Replying to cypherpunks:

STR: https://ia600201.us.archive.org/1/items/OrsonWellesMrBruns/381030.ogg If you don't see OS, test it on Windoze ;)

Works for me on my Windows 7 machine. Do you have steps to reproduce that? Does this happen with a freshly downloaded Tor Browser 7.0a3 (settings kept to the default ones)?

Trac:
Status: new to needs_information

Hmm, seems to be e10s off only. Confirmed on Win XP.

Replying to cypherpunks:

Hmm, seems to be e10s off only. Confirmed on Win XP.

Works for me as well on my Windows 7 machine. I set browser.tabs.remote.autostart.2 to false, restarted Tor Browser and clicked the link. The controls are still visible. So, hrm.

Trac:

Replying to gk:

Replying to cypherpunks:

Hmm, seems to be e10s off only. Confirmed on Win XP.

Works for me as well on my Windows 7 machine. I set browser.tabs.remote.autostart.2 to false, restarted Tor Browser and clicked the link. The controls are still visible. So, hrm. This is really hrm, because your STR gives on my Windows 7 machine (the same as on XP).

yawning, we need you to update the whitelist, while TBB devs are lurking for other bugs :) (Upgrading to "chrome://global/content/bindings/videocontrols.css", "chrome://global/skin/media/videocontrols.css", etc)

Trac:
Status: needs_information to assigned
Owner: tbb-team to yawning
Keywords: N/A deleted, ff52-esr added

I am updating the whitelist along with other followup work for #22459 (moved).

Trac:
Cc: N/A to tbb-team
Owner: yawning to mcs

Trac:
Summary: Adjust #19837 (moved) for ff52-esr to Adjust #19837 (moved) for ff52-esr (update our content policy whitelist)

Here is a patch that expands the whitelist: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug22104-01

Kathy and I decided to use a regex pattern match for the items under chrome://global/skin/media because there are a lot of items there that need to be whitelisted. I don't think using regex will slow things down too much and it will be less fragile, e.g., currently things break when Mozilla adds an image and we don't have test cases that exposes everything that needs to be whitelisted for audio/video playback.

Trac:
Keywords: TorBrowserTeam201705 deleted, TorBrowserTeam201706R added
Status: assigned to needs_review

I just tested the video file and it looks good. The code also looks good to me.

Applied to master: commit 46947ad2a818a89643d75ca2397feb39fc6ef8c3 (and even the login text filed on Trac are working again ;) ).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #22459 (moved)

moved to tpo/applications/tor-browser#22104 (closed)