Opened 2 years ago

Closed 2 years ago

#22105 closed enhancement (fixed)

define a more generic LIBFUZZER = ... in Makefile.in

Reported by: toralf Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version: Tor: 0.3.0.6
Severity: Minor Keywords:
Cc: dgoulet Actual Points:
Parent ID: Points: .1
Reviewer: Sponsor:

Description

The current value

LIBFUZZER = /home/nickm/build/libfuzz/libFuzzer.a

isn't portable enough IMO.
BTW if I configure the sources (with clang 3.9.1):

CC="clang" ./configure --config-cache --enable-expensive-hardening --enable-libfuzzer

then I run during make into

$ make
make  all-am
make[1]: Entering directory '/home/tfoerste/devel/tor'
  AR       src/ext/keccak-tiny/libkeccak-tiny.a
  AR       src/trunnel/libor-trunnel.a
  CC       src/ext/trunnel/src_trunnel_libor_trunnel_testing_a-trunnel.o
clang-3.9: error: unsupported argument 'trace-pc-guard' to option 'fsanitize-coverage='
clang-3.9: error: unsupported argument 'trace-div' to option 'fsanitize-coverage='
make[1]: *** [Makefile:7704: src/ext/trunnel/src_trunnel_libor_trunnel_testing_a-trunnel.o] Error 1
make[1]: Leaving directory '/home/tfoerste/devel/tor'
make: *** [Makefile:3044: all] Error 2

at a stable (hardened) Gentoo Linux.

Child Tickets

Change History (8)

comment:1 Changed 2 years ago by toralf

Component: - Select a componentCore Tor/Tor
Milestone: Tor: 0.3.0.x-final
Severity: NormalMinor
Type: defectenhancement
Version: Tor: 0.3.0.6

comment:2 Changed 2 years ago by nickm

Points: .1

comment:3 Changed 2 years ago by arma

Milestone: Tor: 0.3.0.x-finalTor: 0.3.1.x-final

I'm moving to the current upcoming milestone, so this ticket doesn't get lost. People can move it to 0.3.2 if they want.

comment:4 Changed 2 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:5 Changed 2 years ago by nickm

Cc: dgoulet added

dgoulet, what do you think about having this just do "-lFuzzer", and require that you have libFuzzer in an appropriate path if you're going to be messing around with libfuzzer support?

comment:6 Changed 2 years ago by nickm

Status: acceptedneeds_review

For review in bug22105_031.

comment:7 Changed 2 years ago by dgoulet

Status: needs_reviewmerge_ready

That's much better than me changing the path to my home directory :).

lgtm;

comment:8 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged and pushed; thank you!

Note: See TracTickets for help on using tickets.