Opened 2 years ago

Closed 2 years ago

#22109 closed enhancement (implemented)

Test that own version passes directory authority checks

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:


We recently made the directory authority version checks stricter.

In the unit tests, we should check that both our short and long versions pass the directory authority version checks. (The short is put in our descriptor, the long is sent over the control port. Maybe we should document this.)

Before a relay posts a descriptor, we should check that directory authorities will accept our version, and warn if we think they won't.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by arma

I'm a fan of doing this operation in the unit tests.

It's less clear to me that we need the code in the shipped Tor. Can we just avoid shipping a Tor that fails its unit tests?

comment:2 Changed 2 years ago by nickm

Owner: set to nickm
Status: newaccepted

Unit test added in bug22109. Also added a test to make sure that versions like those described in #22110 are acceptable.

comment:3 Changed 2 years ago by nickm

Status: acceptedneeds_review

comment:4 Changed 2 years ago by catalyst

Status: needs_reviewmerge_ready

Looks good to me!

comment:5 Changed 2 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

Thanks! Merging!

Note: See TracTickets for help on using tickets.