Opened 2 years ago

Closed 2 years ago

#22128 closed defect (fixed)

Refactor body of connection_dir_client_reached_eof()

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: .1
Parent ID: #21650 Points: .1
Reviewer: Sponsor: Sponsor4

Description

What's this 630-line function doing in our codebase?

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by nickm

Please review refactor_dir_client_handler ?

On gitlab at https://gitlab.com/nickm_tor/tor/merge_requests/20 .

This is a pretty straightfoward mechanical refactoring that tries to leave as much of the code alone as possible.

comment:2 Changed 2 years ago by nickm

Status: newneeds_review

comment:3 Changed 2 years ago by nickm

(If you're looking at diffs, make sure to use 'diff -b' or you will see lots of indentation changes)

comment:4 Changed 2 years ago by catalyst

Status: needs_reviewmerge_ready

Looks good to me. I do see some places that could use further refactoring, like some of the complicated logging calls. Also the if-else chains dealing with stringifying compression methods could go into a switch-statement in a helper function.

comment:5 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merging as a likely step forward. Thanks for the review!

Agreed with the logging calls. The if-else chains will probably all get rewritten as part of ahf's #21667 work when he starts handling the new compression methods.

Note: See TracTickets for help on using tickets.