Opened 2 years ago

Closed 2 years ago

#22143 closed defect (fixed)

Implement May 3 updates to diff format in prop140

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: TorCoreTeam201705
Cc: ahf Actual Points: .3
Parent ID: #13339 Points: 1
Reviewer: Sponsor: Sponsor4-must

Description

There are 4 changes to make here:

  • The first digest in our diff code must correspond to the digest-as-signed of the consensus document.
  • We must accept <n>,$d as an ed command.
  • We must have the first command in all our generated diffs be a command that deletes the signatures.
  • We must change our consdiffmgr index code to index diffs by the digest-as-signed of the original document.

Thanks to Taylor Yu and Alexander Færøy for helping me figure out the right solution here.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by nickm

Owner: set to nickm
Status: newassigned

comment:2 Changed 2 years ago by ahf

Cc: ahf added

comment:3 Changed 2 years ago by nickm

Actual Points: .3
Status: assignedneeds_review

Branch ticket22143 is now ready for review. That went quickly. Thank goodness for unit tests! Coverage is still high.

comment:4 Changed 2 years ago by nickm

comment:5 Changed 2 years ago by ahf

Status: needs_reviewmerge_ready

Looks good. Two minor comments and one of them might already be in the pipeline.

comment:6 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

Fixed those and merged.

Note: See TracTickets for help on using tickets.