Opened 15 months ago

Closed 6 months ago

#22145 closed defect (fixed)

Document which interface is used for DNS requests in the context of OutboundBindAddressOR/Exit

Reported by: cypherpunks Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version: Tor: 0.3.0.6
Severity: Normal Keywords: easy, tor-doc, manpage, review-group-28
Cc: Actual Points:
Parent ID: Points: .5
Reviewer: Sponsor:

Description

In #17975 two new options have been added:

  • OutboundBindAddressOR
  • OutboundBindAddressExit

The manual page makes no clear statement which interface is used for DNS traffic.

https://trac.torproject.org/projects/tor/ticket/17975#comment:13
hints towards OutboundBindAddressOR, but users should not be required to search the bugtracker find out about that.

Child Tickets

Attachments (3)

0006-Doc-edited-about-DNS-Requests.patch (967 bytes) - added by aruna1234 7 months ago.
0007-Doc-edited-about-DNS-Requests.patch (1007 bytes) - added by aruna1234 7 months ago.
0008-Doc-edited-specifying-DNS-requests.patch (1.4 KB) - added by aruna1234 7 months ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 15 months ago by cypherpunks

Version: Tor: 0.3.0.6

comment:2 Changed 15 months ago by teor

Keywords: easy doc added

The answer is:

  • OutboundBindAddressOR is used for OR and directory (DirPort) connections:
    • directory_initiate_request()
    • connection_or_connect()
  • OutboundBindAddressExit is used for Exit connections:
    • connection_exit_connect()
  • an unspecified address (typically, the OS routing table) is used for all other connections:
    • evdns_base_resolve_*()
    • are there any other connection types?
Last edited 15 months ago by teor (previous) (diff)

comment:3 Changed 13 months ago by dgoulet

Milestone: Tor: unspecified

Missing milestone.

comment:4 Changed 12 months ago by nickm

Keywords: tor-doc manpage added; doc removed
Points: .5

Changed 7 months ago by aruna1234

comment:5 Changed 7 months ago by aruna1234

Document edited as OutboundBindAddressExit() resposible for DNS requests.

comment:6 Changed 7 months ago by cypherpunks

Status: newneeds_revision

version.This

Please change that to,

version. This

Changed 7 months ago by aruna1234

comment:7 Changed 7 months ago by cypherpunks

Status: needs_revisionneeds_review

comment:8 Changed 7 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.3.x-final

comment:9 Changed 7 months ago by teor

Status: needs_reviewneeds_revision

Thanks for this patch, but the sentence you wrote is not correct.

See:
https://trac.torproject.org/projects/tor/ticket/22145#comment:2

Instead, we should explain under OutboundBindAddress that it does not apply to DNS requests.

Changed 7 months ago by aruna1234

comment:10 Changed 7 months ago by aruna1234

Doc edited by mentioning in OutboundBindAddress that it is not used for DNS Requests.

comment:11 Changed 7 months ago by teor

Status: needs_revisionmerge_ready

Thanks! This looks good.
We don't need a changes file, because it's a documentation-only change,

We will need to squash all the patch files attacked to this ticket to get the final commit,

In future, for small commits like this, can you put all the changes in each patch file?
That makes it easier for us to squash.

Or, you can tell us a branch on a public git repository, like github,com. Branches are also easy to squash.

comment:12 Changed 7 months ago by teor

Please see my branch bug22145_032, which squashes the patches in this ticket.

comment:13 in reply to:  11 Changed 7 months ago by aruna1234

Replying to teor:

Thanks! This looks good.
We don't need a changes file, because it's a documentation-only change,

We will need to squash all the patch files attacked to this ticket to get the final commit,

In future, for small commits like this, can you put all the changes in each patch file?
That makes it easier for us to squash.

Or, you can tell us a branch on a public git repository, like github,com. Branches are also easy to squash.

Thanks!
Will take care from next time.

comment:14 Changed 7 months ago by nickm

Keywords: review-group-28 added

comment:15 Changed 6 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged, and added a changes file.

Note: See TracTickets for help on using tickets.