Opened 22 months ago
Closed 15 months ago
#22147 closed enhancement (fixed)
Add Onionoo's exit_addresses field
Reported by: | cypherpunks | Owned by: | irl |
---|---|---|---|
Priority: | Medium | Milestone: | |
Component: | Metrics/Relay Search | Version: | |
Severity: | Normal | Keywords: | metrics-2017 |
Cc: | Actual Points: | ||
Parent ID: | Points: | ||
Reviewer: | Sponsor: |
Description
Ideally display them similarly to the entries in the MyFamily lists.
Child Tickets
Attachments (3)
Change History (27)
comment:1 Changed 22 months ago by
Summary: | add exit_addresses onionoo field to at atlas → add exit_addresses onionoo field |
---|
comment:2 follow-ups: 3 5 Changed 22 months ago by
Owner: | changed from irl to cypherpunks |
---|---|
Status: | new → accepted |
comment:3 follow-up: 4 Changed 22 months ago by
Replying to cypherpunks:
I plan to solve this confusion by merging the
or_addresses
andexit_addresses
field and using the result for displaying the exit addresses.
I'm not sure about this. Maybe when I see it I'll have a better idea. OR addresses have ports, exit addresses do not. While I can see how these are related, I wonder what the best presentation would be. It also cannot be assumed that an empty exit_addresses means that it will exit from the OR address, as it may just be that the exit scanner is broken, so that confusion should be avoided also.
comment:4 follow-up: 6 Changed 22 months ago by
Replying to irl:
Replying to cypherpunks:
I plan to solve this confusion by merging the
or_addresses
andexit_addresses
field and using the result for displaying the exit addresses.
I'm not sure about this. Maybe when I see it I'll have a better idea. OR addresses have ports, exit addresses do not.
I will strip off the ports before merging the fields.
While I can see how these are related, I wonder what the best presentation would be. It also cannot be assumed that an empty exit_addresses means that it will exit from the OR address, as it may just be that the exit scanner is broken, so that confusion should be avoided also.
From the wording of the Onionoo description i assumed the OR address is always an exit address. Is this not correct?
comment:5 Changed 22 months ago by
Replying to cypherpunks:
This means exit relays that use the same address(es) for both OR and exiting have no
exit_addresses
field. Showing the field as empty (ornone
as is common for empty fields in Atlas) is confusing IMO.
I disagree, there is a distinction between OR address and exit_address.
I plan to solve this confusion by merging the
or_addresses
andexit_addresses
field and using the result for displaying the exit addresses.
Please do not merge them.
comment:6 Changed 22 months ago by
Replying to cypherpunks:
From the wording of the Onionoo description i assumed the OR address is always an exit address. Is this not correct?
No this is not correct.
See also:
https://www.torproject.org/docs/tor-manual.html.en#OutboundBindAddressExit
comment:7 follow-up: 8 Changed 22 months ago by
Onionoo is rather clear about exit_addresses:
Only those addresses are listed that are different from onion-routing addresses
the same level of clearness should be on the atlas page displaying exit_addresses.
Empty exit_addresses for exits that exit with their OR IP address are clear in the context of the above statement.
comment:8 Changed 22 months ago by
Replying to nusenu:
Onionoo is rather clear about exit_addresses:
Only those addresses are listed that are different from onion-routing addresses
the same level of clearness should be on the atlas page displaying exit_addresses.
Empty exit_addresses for exits that exit with their OR IP address are clear in the context of the above statement.
Okay, I'll not merge the two fields and add emphasis to the distinction in a tooltip.
comment:9 follow-up: 10 Changed 22 months ago by
thanks.
The title for the list of exit_addresses could be
"Not-announced Exit IP Addresses"
Changed 22 months ago by
Attachment: | 0001-Add-a-field-for-the-exit-addresses-of-relays.patch added |
---|
comment:10 Changed 22 months ago by
Status: | accepted → needs_review |
---|
Replying to nusenu:
thanks.
The title for the list of exit_addresses could be
"Not-announced Exit IP Addresses"
I kept the title similar to existing fields by simply naming it Exit Addresses
.
I've opened #22160 for improving the address list style because some relays have more than two exit addresses which leads to styling issues.
comment:11 follow-up: 12 Changed 22 months ago by
Also note that this list can be rather long (biggest entry I've seen so fare was 297 chars long).
That is why I suggested to use a vertical style like the fingerprints in family blocks.
comment:12 Changed 22 months ago by
comment:13 Changed 22 months ago by
this one is 173 chars long:
https://onionoo.torproject.org/details?fingerprint=8ED43EC3683D7E261BB8FEA4EA8122952968CF8E&
fields=exit_addresses
comment:14 Changed 21 months ago by
Status: | needs_review → needs_revision |
---|
Can the patch be updated to work better with the longer lists?
Changed 21 months ago by
Attachment: | 0001-Support-long-address-lists.patch added |
---|
Changed 21 months ago by
Attachment: | 0002-Reorder-fields-to-group-similar-styling-together.patch added |
---|
comment:15 Changed 21 months ago by
Status: | needs_revision → needs_review |
---|
I've attached two additional patches. 0001-Support-long-address-lists.patch uses pre
blocks to display addresses, and fields that represent arrays of addresses are made scrollable. 0002-Reorder-fields-to-group-similar-styling-together.patch reorders the fields so fields that use pre
blocks are grouped together which IMO looks better.
#22160 is now a child of this ticket because these patches fix the issue that that ticket addresses.
Curiously the number of exit addresses per relay have been reduced significantly, at the time of writing there are at most 3 exit addresses.
comment:16 Changed 21 months ago by
I've not looked at this yet, but I think I'm going to find that having things grouped by presentation as opposed to content is less than optimal...
(I've closed #22160 as this is being done here and only affects this bug anyway.)
comment:17 Changed 19 months ago by
Sorry, could these patches be rebased against the current master?
comment:18 Changed 19 months ago by
Status: | needs_review → needs_revision |
---|
comment:19 Changed 17 months ago by
Summary: | add exit_addresses onionoo field → Add Onionoo's exit_addresses field |
---|
Use more capital letters in summary.
comment:20 Changed 17 months ago by
Keywords: | metrics-2018 added |
---|
comment:21 Changed 17 months ago by
Keywords: | metrics-2017 added; metrics-2018 removed |
---|
comment:22 Changed 15 months ago by
Owner: | changed from cypherpunks to irl |
---|---|
Status: | needs_revision → assigned |
Moving this into my queue.
comment:23 Changed 15 months ago by
Status: | assigned → accepted |
---|
comment:24 Changed 15 months ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
Fixed in e565a2ea1952901b95ed93c3536652378493a5d8.
I have not included the presentation patches. If this becomes an issue in the future we can take another look at this.
Replying to cypherpunks:
I don't think this is ideal because it would be inconsistent with the style of the OR and Dir addresses fields.
Regarding the implementation of this feature, the Onionoo documentation on the
exit_addresses
field states it is anThis means exit relays that use the same address(es) for both OR and exiting have no
exit_addresses
field. Showing the field as empty (ornone
as is common for empty fields in Atlas) is confusing IMO. I plan to solve this confusion by merging theor_addresses
andexit_addresses
field and using the result for displaying the exit addresses.